From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B72C0015E for ; Fri, 28 Jul 2023 08:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uChlnApkjMO8Npeg4OYKWk2edmU+XkTlV/jOLeMp6ws=; b=pmfuMOwgXq9DUK ox9tPs+gy0D5avy6q2B6+aJCZT+JaddzZY2U3ivWnGl50zkr1t9OpUZBZ6mVGejPJKQ36AR8280OX g2DOTEMMMDRXiNcGLWPqYRPtYgT4QryKcW2ztL/BxfyxDnUNZshFAP3a/bpCNC3KvmGxfON8i9ODW /3f8HjwVzwbRfQrOU5dS9Q7PqZvX9Zq11xnc64lfJOaP2KAr9OsaN+2xG9LkFbRkixcg/426DBKaq XEt6K5bhoAaPlvAtHWvjcwoK90eMYhypMqCYoqQGsJmIJpKBO1RlvVHhKrv2bSJa4eFDczH+0Dp5m IIujpF5sJFkMr2iE4aRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPIfc-002MpD-2L; Fri, 28 Jul 2023 08:17:56 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPIfZ-002Mmu-0O for linux-arm-kernel@lists.infradead.org; Fri, 28 Jul 2023 08:17:54 +0000 Received: from [192.168.1.108] (unknown [103.86.18.216]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A61028DA; Fri, 28 Jul 2023 10:16:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1690532208; bh=K7YpSXytgf5L+qYcFuRlbKHUV6MG1D33noUTvi8jI4M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=h7fqUqjjzLS2AWYjIqijo2Boti1lF44IA362h2EJ7ARLsawbO9Pzk/EPWKk/E31p9 ZSAy4cWmAUaZ8C4FGeU2wXFFtTxP+Tc3NLfW26DlbCCUYwpInyviuI8L2KxyS9rWBY MEADY5qcwwrcgp1G3ouJFQS2RGDMvljvoOVt7Gbw= Message-ID: <1070170e-830c-4752-bad5-8f653ebd80a4@ideasonboard.com> Date: Fri, 28 Jul 2023 13:47:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/2] media: i2c: imx519: Support for the Sony IMX519 sensor To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Lee Jackson , Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , Hans Verkuil , Shawn Tu , Nicholas Roth , Mikhail Rudenko , kieran.bingham@ideasonboard.com, Marco Felsch , jacopo.mondi@ideasonboard.com References: <20230727154108.308320-3-umang.jain@ideasonboard.com> <202307281538.bqZ5kcV9-lkp@intel.com> Content-Language: en-US From: Umang Jain In-Reply-To: <202307281538.bqZ5kcV9-lkp@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_011753_305745_EC8C5C6E X-CRM114-Status: GOOD ( 21.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/28/23 12:56 PM, kernel test robot wrote: > Hi Umang, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on media-tree/master] > [also build test ERROR on soc/for-next linus/master v6.5-rc3 next-20230727] > [cannot apply to sailus-media-tree/streams] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Umang-Jain/media-dt-bindings-imx519-Add-IMX519-DT-bindings/20230727-234440 > base: git://linuxtv.org/media_tree.git master > patch link: https://lore.kernel.org/r/20230727154108.308320-3-umang.jain%40ideasonboard.com > patch subject: [PATCH 2/2] media: i2c: imx519: Support for the Sony IMX519 sensor > config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230728/202307281538.bqZ5kcV9-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce: (https://download.01.org/0day-ci/archive/20230728/202307281538.bqZ5kcV9-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202307281538.bqZ5kcV9-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > drivers/media/i2c/imx519.c: In function 'imx519_open': >>> drivers/media/i2c/imx519.c:1170:30: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function) This comes from the bcm2835-unicam for Rpi's that's being worked upon. And I was testing this driver on top of it. > 1170 | try_fmt_meta->code = MEDIA_BUS_FMT_SENSOR_DATA; > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/media/i2c/imx519.c:1170:30: note: each undeclared identifier is reported only once for each function it appears in > drivers/media/i2c/imx519.c: In function 'imx519_enum_mbus_code': > drivers/media/i2c/imx519.c:1319:30: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function) > 1319 | code->code = MEDIA_BUS_FMT_SENSOR_DATA; > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/media/i2c/imx519.c: In function 'imx519_enum_frame_size': > drivers/media/i2c/imx519.c:1346:34: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function) > 1346 | if (fse->code != MEDIA_BUS_FMT_SENSOR_DATA || fse->index > 0) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/media/i2c/imx519.c: In function 'imx519_update_metadata_pad_format': > drivers/media/i2c/imx519.c:1382:28: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function) > 1382 | fmt->format.code = MEDIA_BUS_FMT_SENSOR_DATA; > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/media/i2c/imx519.c: In function 'imx519_get_pad_format': > drivers/media/i2c/imx519.c:1404:33: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function) > 1404 | MEDIA_BUS_FMT_SENSOR_DATA; > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > vim +/MEDIA_BUS_FMT_SENSOR_DATA +1170 drivers/media/i2c/imx519.c > > 1149 > 1150 static int imx519_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > 1151 { > 1152 struct imx519 *imx519 = to_imx519(sd); > 1153 struct v4l2_mbus_framefmt *try_fmt_img = > 1154 v4l2_subdev_get_try_format(sd, fh->state, IMAGE_PAD); > 1155 struct v4l2_mbus_framefmt *try_fmt_meta = > 1156 v4l2_subdev_get_try_format(sd, fh->state, METADATA_PAD); > 1157 struct v4l2_rect *try_crop; > 1158 > 1159 mutex_lock(&imx519->mutex); > 1160 > 1161 /* Initialize try_fmt for the image pad */ > 1162 try_fmt_img->width = supported_modes_10bit[0].width; > 1163 try_fmt_img->height = supported_modes_10bit[0].height; > 1164 try_fmt_img->code = imx519_get_format_code(imx519); > 1165 try_fmt_img->field = V4L2_FIELD_NONE; > 1166 > 1167 /* Initialize try_fmt for the embedded metadata pad */ > 1168 try_fmt_meta->width = IMX519_EMBEDDED_LINE_WIDTH; > 1169 try_fmt_meta->height = IMX519_NUM_EMBEDDED_LINES; >> 1170 try_fmt_meta->code = MEDIA_BUS_FMT_SENSOR_DATA; > 1171 try_fmt_meta->field = V4L2_FIELD_NONE; > 1172 > 1173 /* Initialize try_crop */ > 1174 try_crop = v4l2_subdev_get_try_crop(sd, fh->state, IMAGE_PAD); > 1175 try_crop->left = IMX519_PIXEL_ARRAY_LEFT; > 1176 try_crop->top = IMX519_PIXEL_ARRAY_TOP; > 1177 try_crop->width = IMX519_PIXEL_ARRAY_WIDTH; > 1178 try_crop->height = IMX519_PIXEL_ARRAY_HEIGHT; > 1179 > 1180 mutex_unlock(&imx519->mutex); > 1181 > 1182 return 0; > 1183 } > 1184 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel