Re: [PATCH v5 1/4] arm64: dts: rockchip: Add light/proximity sensor to Pinephone Pro

[Heiko Stuebner <heiko@sntech.de>]

Hi,

Am Dienstag, 25. November 2025, 04:47:00 Mitteleuropäische Normalzeit schrieb Rudraksha Gupta via B4 Relay:

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index 6f97e57f36f5..2d2858ee149e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -520,6 +520,16 @@ touchscreen@14 {
>  		touchscreen-size-x = <720>;
>  		touchscreen-size-y = <1440>;
>  	};
> +
> +	light-sensor@48 {
> +		compatible = "sensortek,stk3311";
> +		proximity-near-level = <300>;

proximity-next-... belongs below pinctrl-*


> +		reg = <0x48>;
> +		interrupt-parent = <&gpio4>;
> +		interrupts = <RK_PD3 IRQ_TYPE_EDGE_FALLING>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&light_int_l>;
> +	};
>  };
>  
>  &i2c4 {
> @@ -689,6 +699,12 @@ vcc1v8_codec_en: vcc1v8-codec-en {
>  		};
>  	};
>  
> +	stk3311 {

please sort nodes alphabetically
(stk3311 after vcc1v8-codec-en is incorrect)


> +		light_int_l: light-int-l {
> +			rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_input_pull_up>;
> +		};
> +	};
> +
>  	wireless-bluetooth {
>  		bt_wake_pin: bt-wake-pin {
>  			rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;
> 
> 


Heiko