From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A869C52D73 for ; Thu, 8 Aug 2024 07:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XcW0mMoE7iE3zPYAjQwvzJP8+fdWpu8rQms+GgCZm3M=; b=Pn5HV4RAnO2juPRj1284WAVJIB MzCoSGtupbjKOGPxhD7P/S/JYcuk+/Bo4oUaKqc95o1pFV7DE1fuMZuObq4sOTN+WTwFSkl+5fqMZ ydlTL4Zy8YtqVvWayngkWOnBrK+8Nz8+35VtfIZi90kbs2KBN0XGF6onDoKphvpKYgjHwdzAGX8lP kSKCKLrGYT4e0wT/dhRFcC+WEokQhPScskApDLiaaL3sVDii34SRhqCmJgH7xIdFuPSfB2P8Xp70F diY7Jq1z6+cwqcPCITpSy+aaR3k54gdwDG7eiVdnXyOgSslMbI/vZhaMVYY9yc0GXUkXVlROgREB7 RSZnC7Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbxzq-00000007UwP-1jtv; Thu, 08 Aug 2024 07:55:42 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbxzG-00000007Upj-02aA; Thu, 08 Aug 2024 07:55:07 +0000 Received: from i53875a9f.versanet.de ([83.135.90.159] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sbxz5-0000Hh-CK; Thu, 08 Aug 2024 09:54:55 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Detlev Casanova Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Geert Uytterhoeven , "Rafael J . Wysocki" , Finley Xiao , Jagan Teki , Elaine Zhang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: Add power-domain header for RK3576 SoCs Date: Thu, 08 Aug 2024 09:54:54 +0200 Message-ID: <10908017.3WhfQktd6Z@diego> In-Reply-To: <3310992.44csPzL39Z@trenzalore> References: <20240802151647.294307-1-detlev.casanova@collabora.com> <3310992.44csPzL39Z@trenzalore> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_005506_090227_E76F4FC6 X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Detlev, Am Dienstag, 6. August 2024, 18:34:41 CEST schrieb Detlev Casanova: > On Sunday, 4 August 2024 05:56:39 EDT Krzysztof Kozlowski wrote: > > On 02/08/2024 17:14, Detlev Casanova wrote: > > > From: Finley Xiao > > > > > > Define power domain IDs as described in the TRM. > > > > Please use subject prefixes matching the subsystem. You can get them for > > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > > your patch is touching. For bindings, the preferred subjects are > > explained here: > > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patche > > s.html#i-for-patch-submitters > > > Signed-off-by: Finley Xiao > > > [reword] > > > Signed-off-by: Detlev Casanova > > > --- > > > > > > include/dt-bindings/power/rk3576-power.h | 30 ++++++++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > create mode 100644 include/dt-bindings/power/rk3576-power.h > > > > This is part of bindings. > > > > > diff --git a/include/dt-bindings/power/rk3576-power.h > > > b/include/dt-bindings/power/rk3576-power.h > > Missing vendor prefix. This should be named after compatible. > > Looks like all other rockchip power bindings use the include/dt-bindings/ > power/rkXXXX.h format. Should I keep that way ? there is also rockchip,rv1126-power.h , so please follow Krzysztof's suggestion. Older header namings need to stay the same of course but that shouldn't keep us from updating naming schemes to better work in new additions.