From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E151EE14DE for ; Thu, 7 Sep 2023 11:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3rkUFdxVTrJ625L4Jq8t9MQBP8uRXc9q0QpGAwauPIo=; b=05auVleMk94Wr8 7t1S1t8D4tCm0MNInz+HGj7ouiCv79bvK4HFQ5Kqqp9CtjvAvZ2tlqOh+seOKq1NiJNstFpmzngQ7 5Xk/kilCmHnd4jSjzE5HmbswOu/+SWJ7BLSDTXoEmGx5hMqAp6SapjmDHop+48ZqAljxaPoH5ZuNx EwSwmG5fvvJn+TuVnA0wtxmDhTi40KIdgp304QNkNYHq1gHAvrHQAmSx/bIPS2buE4nepJ3MgsdJg IKJnjTQdz5AsFp8b90HpWDemHcRsfRxB7VtfkkdSn12ruvNu9ffyL5rm8u+yFilceQn9FtpOTekNZ iEawx7TbkTkRnJAWUpWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qeCs6-00Bz3W-3D; Thu, 07 Sep 2023 11:08:27 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qeCs4-00Bz2R-0b for linux-arm-kernel@lists.infradead.org; Thu, 07 Sep 2023 11:08:25 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-401da71b83cso9398245e9.2 for ; Thu, 07 Sep 2023 04:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694084900; x=1694689700; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G88lP2VW9W0ey1BM427zqcg+F+UpGhl5q2J3uTfo6Co=; b=DxeD+rbvbTzq4tvQr9amXobzNZqKBXeSWHwTihP9M6f9TJIqei1QM1CankcHXR5SHr COzWM76kOYJu0P3RjPC5ZfSg51bzSKz7iqxs4GeMliF7Mv/VH0jNYJpcvttX43X9oOAO rW2HExsSYrG728jvZs3WqzeRFdJLIzs2mbyIou7N+BdGTX6IpWjZgFSmrgNXVZdElwF+ 6JpfaLQDZ7nY/12LwZU7036dYFEMBTXZkVc3TMlFMfulqQpsfNTaaTfKzC5PQHgQvBY8 6vzihDapN73kITYnGwq+k5n95LDpksuMMTT3de0ZF1Ba3SybpL6ESeFikmMG3bvxnXhz mGVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694084900; x=1694689700; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G88lP2VW9W0ey1BM427zqcg+F+UpGhl5q2J3uTfo6Co=; b=InI7SR0nGPQLlZU9zASnLNemApDKHK3c+/6NK7TaUf5gf/+eaWNmpJ1Ug8lEtrhous pIM9//J5HCU/hK1bcYOQ8TeRGjwnPInQZIO6idsZ2QfsNArJwWt5/ACE5Oo49YME8USd ngBJz0W/kGyV/UTWGQd5YaagH992pHC6kwrcxYloepRrwBYhO9Xke4vR7fGw6RKemg8g TS/GNMZHXsaoitJfHiTV3GnXGUHUMGHjFNQLXeexQcUPfzEKggLL1kaKosEnl/ATKMQo uDSv6oBSy+9JYbVXzJqQcULkAiCxoEmBgHMVmPtPYD53cloZQ/vOOE2Q+LYbnj4I8RAF EeYg== X-Gm-Message-State: AOJu0Yzxiibd/oEl9WIx1SH3Zy0BbcQyll78jqXQ9j+ZKbjGUsbcij9c Eb4lKAFzxIv4WxbcPRbOqIgq/Q== X-Google-Smtp-Source: AGHT+IHGT591APG6CRNW4zuyJuEfxCr1FfGrojCK5qI1ehGXhuwAoMXIKQPf6+hAJXIGsQZ5/i+wTg== X-Received: by 2002:a1c:ed08:0:b0:3fe:2b60:b24e with SMTP id l8-20020a1ced08000000b003fe2b60b24emr4801517wmh.29.1694084900263; Thu, 07 Sep 2023 04:08:20 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id ay30-20020a5d6f1e000000b0031f65cdd271sm3999677wrb.100.2023.09.07.04.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 04:08:19 -0700 (PDT) Date: Thu, 7 Sep 2023 14:08:17 +0300 From: Dan Carpenter To: AngeloGioacchino Del Regno Cc: Harshit Mogalapalli , Sebastian Reichel , Matthias Brugger , Andy Shevchenko , ChiaEn Wu , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, error27@gmail.com Subject: Re: [PATCH] power: supply: mt6370: Fix missing error code in mt6370_chg_toggle_cfo() Message-ID: <1092ffb3-0238-4dc0-baf3-344a653fca3f@kadam.mountain> References: <20230906084815.2827930-1-harshit.m.mogalapalli@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230907_040824_226068_91FB5E85 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 07, 2023 at 12:43:12PM +0200, AngeloGioacchino Del Regno wrote: > Il 06/09/23 10:48, Harshit Mogalapalli ha scritto: > > When mt6370_chg_field_get() suceeds, ret is set to zero and returning > > zero when flash led is still in strobe mode looks incorrect. > > > > Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver") > > Signed-off-by: Harshit Mogalapalli > > --- > > This is based on static analysis with smatch, only compile tested. > > --- > > drivers/power/supply/mt6370-charger.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c > > index f27dae5043f5..a9641bd3d8cf 100644 > > --- a/drivers/power/supply/mt6370-charger.c > > +++ b/drivers/power/supply/mt6370-charger.c > > @@ -324,7 +324,7 @@ static int mt6370_chg_toggle_cfo(struct mt6370_priv *priv) > > if (fl_strobe) { > > dev_err(priv->dev, "Flash led is still in strobe mode\n"); > > - return ret; > > + return -EINVAL; > > I think that returning 0 here was intentional, but I agree on a return ret > here being both confusing and wrong. If it's a success path then probably we should remove the dev_err(). regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel