From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9414DC7618F for ; Mon, 22 Jul 2019 16:33:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 684122190F for ; Mon, 22 Jul 2019 16:33:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JO8gBHPo"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Kwd7+jRb"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Kwd7+jRb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 684122190F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JuHzw/QLV6RCDIY8BlKby/rlusj5lYcCUFL6E8bNm3s=; b=JO8gBHPoDdnKkIGp3TN40OrIU gfJ4U4cgCYylceDBwWSlV6Qj5AcemQm6mqF8iw7hFIhmgORCVYOyO+tTIzWeqXaVIWAW2Ki8MAZww EwNOuoqHo5lVpFVc7CivWJx6LUxyR44OKkDsFMlg2MEdmyNgpBEKEJEOrG4y/x7uQjU11s8qs00xd LU805kFMXqWsQPWlE2ZJQz7UhqAsrd3CUKz5N9dPTq94b+BIpe3ug6VqcLss+V95pWywkjZklfRBR s789q0h1Kpmn5cXuTYFQ23iJzDJnmX75Bqqq+ymBozaYX2qvdc3Qk7rHAhbPgXQDDbqvULx24zxWW Ryc6VeaXQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpbFX-0004Qv-4W; Mon, 22 Jul 2019 16:33:19 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpbEj-0004B6-Jf for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2019 16:32:33 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E527460FE9; Mon, 22 Jul 2019 16:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563813148; bh=FvrMJHRCOLmmPwFfYQKdgXN+b/dK0PJw2qs6twTLHzc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Kwd7+jRbtl41CdptBBt16swkCDlOLa8Qd+W4KPs6uO9joBjCYbxFBm9+Pj5M/75qa ye/fziuAkXn4jO+qFPYO5oytJFHHpQLj31CUp1OHBkgfxOTX20V65GjT1T01a8qjyR 1L2dPcjhdKAIaIfKECjAHK2sRBxj52o1tPTDX+6k= Received: from [10.204.78.89] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: neeraju@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B569A60E59; Mon, 22 Jul 2019 16:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563813148; bh=FvrMJHRCOLmmPwFfYQKdgXN+b/dK0PJw2qs6twTLHzc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Kwd7+jRbtl41CdptBBt16swkCDlOLa8Qd+W4KPs6uO9joBjCYbxFBm9+Pj5M/75qa ye/fziuAkXn4jO+qFPYO5oytJFHHpQLj31CUp1OHBkgfxOTX20V65GjT1T01a8qjyR 1L2dPcjhdKAIaIfKECjAHK2sRBxj52o1tPTDX+6k= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B569A60E59 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=neeraju@codeaurora.org Subject: Re: [PATCH v2] arm64: Force SSBS on context switch To: Will Deacon References: <20190722135309.43186-1-marc.zyngier@arm.com> <8c89dbc4-50ba-6802-e582-d4fe54426261@codeaurora.org> <20190722160429.wasox4nfl6t5jrew@willie-the-truck> From: Neeraj Upadhyay Message-ID: <10931ace-f5fb-43cc-77cb-a27f1f3704fe@codeaurora.org> Date: Mon, 22 Jul 2019 22:02:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190722160429.wasox4nfl6t5jrew@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190722_093229_803591_D10755CB X-CRM114-Status: GOOD ( 14.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Catalin Marinas , Mark Rutland , linux-arm-kernel@lists.infradead.org, Anshuman Khandual Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 7/22/19 9:34 PM, Will Deacon wrote: > On Mon, Jul 22, 2019 at 08:28:15PM +0530, Neeraj Upadhyay wrote: >> On 7/22/19 7:23 PM, Marc Zyngier wrote: >>> +static void ssbs_thread_switch(struct task_struct *next) >>> +{ >>> + if (likely(!(next->flags & PF_KTHREAD)) && >>> + arm64_get_ssbd_state() != ARM64_SSBD_FORCE_ENABLE && >>> + !test_tsk_thread_flag(next, TIF_SSBD)) { >>> + struct pt_regs *regs = task_pt_regs(next); >>> + >>> + if (compat_user_mode(regs)) >>> + set_compat_ssbs_bit(regs); >>> + else if (user_mode(regs)) >>> + set_ssbs_bit(regs); >>> + } >>> +} >>> + >>> /* >>> * We store our current task in sp_el0, which is clobbered by userspace. Keep a >>> * shadow copy so that we can restore this upon entry from userspace. >>> @@ -471,6 +485,7 @@ __notrace_funcgraph struct task_struct *__switch_to(struct task_struct *prev, >>> entry_task_switch(next); >>> uao_thread_switch(next); >>> ptrauth_thread_switch(next); >>> + ssbs_thread_switch(next); >>> /* >>> * Complete any pending TLB or cache maintenance on this CPU in case >> Looks good to me. > I inverted the logic in ssbs_thread_switch() so I could add some comments. > Please double check: > > https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/fixes&id=cbdf8a189a66001c36007bf0f5c975d0376c5c3a > > Will Looks good Thanks Neeraj -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel