From: Hari Nagalla <hnagalla@ti.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <andersson@kernel.org>, <p.zabel@pengutronix.de>,
<martyn.welch@collabora.com>, <nm@ti.com>, <vigneshr@ti.com>,
<kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 4/5] remoteproc: k3: Split out functions common with M4 driver
Date: Sat, 2 Sep 2023 05:44:51 -0500 [thread overview]
Message-ID: <10acb196-b7e4-1b19-6015-c44e72bea1cc@ti.com> (raw)
In-Reply-To: <ZO5LVy9bx7Q3iILi@p14s>
Hi Mathieu,
On 8/29/23 14:47, Mathieu Poirier wrote:
>> Signed-off-by: Martyn Welch<martyn.welch@collabora.com>
>> Signed-off-by: Hari Nagalla<hnagalla@ti.com>
>> ---
>> Changes since v2:
>> - New patch (reordered refactored from v2)
>>
>> Changes since v3:
>> - Removed "ipc_only" element from k3_rproc structure
>> - Refactored to bring 3 more common functions
>>
>> Changes since v4:
>> - None
>>
>> drivers/remoteproc/Makefile | 2 +-
>> drivers/remoteproc/ti_k3_common.c | 513 +++++++++++++++++++
>> drivers/remoteproc/ti_k3_common.h | 103 ++++
>> drivers/remoteproc/ti_k3_dsp_remoteproc.c | 598 ++--------------------
>> 4 files changed, 646 insertions(+), 570 deletions(-)
>> create mode 100644 drivers/remoteproc/ti_k3_common.c
>> create mode 100644 drivers/remoteproc/ti_k3_common.h
> This patch is hard to follow because of all the things it does. Please do the
> structures in one patch and the functions in another.
>
I will re-structure the patches as you suggested for driver and also
separate the device tree node patches to avoid clutter.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-02 10:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 4:45 [PATCH v5 0/5] TI K3 M4F support on AM64x and AM62x SoCs Hari Nagalla
2023-08-08 4:45 ` [PATCH v5 1/5] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs Hari Nagalla
2023-08-08 20:31 ` Rob Herring
2023-08-08 4:45 ` [PATCH v5 2/5] arm64: dts: ti: k3-am62 : Add M4F remote proc node Hari Nagalla
2023-08-08 12:07 ` Nishanth Menon
2023-08-08 4:45 ` [PATCH v5 3/5] arm64: dts: ti: k3-am64 " Hari Nagalla
2023-08-08 12:08 ` Nishanth Menon
2023-08-08 4:45 ` [PATCH v5 4/5] remoteproc: k3: Split out functions common with M4 driver Hari Nagalla
2023-08-29 19:47 ` Mathieu Poirier
2023-09-02 10:44 ` Hari Nagalla [this message]
2023-08-08 4:45 ` [PATCH v5 5/5] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem Hari Nagalla
2023-08-29 20:01 ` Mathieu Poirier
2023-09-02 10:49 ` Hari Nagalla
2023-08-08 12:06 ` [PATCH v5 0/5] TI K3 M4F support on AM64x and AM62x SoCs Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10acb196-b7e4-1b19-6015-c44e72bea1cc@ti.com \
--to=hnagalla@ti.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=martyn.welch@collabora.com \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox