From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E04CC71153 for ; Sat, 2 Sep 2023 10:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NpweH9sQJlJG9jLlFCX1Bf+AI26Z5JHZvx0iE9/Ew0k=; b=r8kCPm3lKR9TSX +kfMNz4r2wxcIbNpbbaUzUsBZLmhUrxy9QVz0EJQoVNTHS/syufwTLmbGoliq/QnnkdHwNZWJWn9U IJt4TbqfF6f8PQBs9w2ilDQnGWso/R6dA3gT6UA99DIr56/l4TpYXeIFH1GI+PhE0Bt5BlXyhHIfJ KTRIto6QUZffZZMB8mCpQxDjtCr7zOufipuuBbNfUHTlgjYwQI7p9Sm11bsdVrCEbq3curHxgECa7 UJz5h1VCWIFCHFoZHIbPDOEYTi51oWe35zjJiTLSTYrhMVLp2pIdmOqRcK3ZD6dMBihzJV9p2nSqZ caEypN8Ad7zmO8i5UEyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qcO7u-001M0B-1M; Sat, 02 Sep 2023 10:45:14 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qcO7q-001Lzg-0S for linux-arm-kernel@lists.infradead.org; Sat, 02 Sep 2023 10:45:12 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 382Aiq0Q052850; Sat, 2 Sep 2023 05:44:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1693651492; bh=MTknmprLmnJQFCQzNZrSewxgOvvJ97mCk4oPPBtNwDw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=dZniak8IzFjCeDlVFVk1v5VGKK7EfUikHGUm46hCdYjObmfF2789xJ08NHl/EtgIf WkYapRH751NYiNgQv6idpB5SUsfSmEfrVxhjvYxfFYJOneqdfl7sy8+s4yhDlzWAGT gQ0imQgr31/gr9PDv+8ZEdyNgmgXrxwUBmhJGNZE= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 382AiqMr004272 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 2 Sep 2023 05:44:52 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sat, 2 Sep 2023 05:44:51 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sat, 2 Sep 2023 05:44:51 -0500 Received: from [10.249.48.175] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 382Aipkg000497; Sat, 2 Sep 2023 05:44:51 -0500 Message-ID: <10acb196-b7e4-1b19-6015-c44e72bea1cc@ti.com> Date: Sat, 2 Sep 2023 05:44:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 4/5] remoteproc: k3: Split out functions common with M4 driver To: Mathieu Poirier CC: , , , , , , , , , , , , References: <20230808044529.25925-1-hnagalla@ti.com> <20230808044529.25925-5-hnagalla@ti.com> Content-Language: en-US From: Hari Nagalla In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230902_034510_369340_184A01D0 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On 8/29/23 14:47, Mathieu Poirier wrote: >> Signed-off-by: Martyn Welch >> Signed-off-by: Hari Nagalla >> --- >> Changes since v2: >> - New patch (reordered refactored from v2) >> >> Changes since v3: >> - Removed "ipc_only" element from k3_rproc structure >> - Refactored to bring 3 more common functions >> >> Changes since v4: >> - None >> >> drivers/remoteproc/Makefile | 2 +- >> drivers/remoteproc/ti_k3_common.c | 513 +++++++++++++++++++ >> drivers/remoteproc/ti_k3_common.h | 103 ++++ >> drivers/remoteproc/ti_k3_dsp_remoteproc.c | 598 ++-------------------- >> 4 files changed, 646 insertions(+), 570 deletions(-) >> create mode 100644 drivers/remoteproc/ti_k3_common.c >> create mode 100644 drivers/remoteproc/ti_k3_common.h > This patch is hard to follow because of all the things it does. Please do the > structures in one patch and the functions in another. > I will re-structure the patches as you suggested for driver and also separate the device tree node patches to avoid clutter. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel