From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1DABC636CC for ; Mon, 13 Feb 2023 11:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UMlZbhXjB5AeCGs61kypL4kq9eHAWZ5hxMHRXXAXOX8=; b=hyEEXz9zmTUfIN 99BbP7WAScwMdHS13xz79n9V14gGwosC26Map7cWzSUuI+uNHCENMoyDu6T3ucyoBjs09pJX+pQWQ g5JPq07mleSjTRH43zUb6xvVkJUcfXKlNaqkjQbWXoP2ZSGmgx0ucU5wb/5t1ozsndzLWc9YdANXG 9qSc1RpEG+ZSufnKgmHpw6PrHWrFLCFIQBdqm7z9XZNi7hGl3ir1EZqjS/jxYpZ6ASYXhOeLAP3EY 2a2xuo9BWqKzSzVsXsfPNd3hdI4DztXGI60skR8yBktXEAw41tPv/Skg5drE311MGhrceazqbj612 zkyDRpbQ4I5T1d6rQTzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWYh-00EH9K-0K; Mon, 13 Feb 2023 10:59:43 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWYR-00EH1H-R2 for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 10:59:31 +0000 Received: by mail-wr1-x429.google.com with SMTP id o15so8415967wrc.9 for ; Mon, 13 Feb 2023 02:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HNRrH6pVFd2ShQx69BQENhHFCRJ2DJdc/TbT0vWDWBA=; b=jcwCUaS5PsaDXY9H+0qskpy7DXmR3b1cP4nVEKDi4Hp/+xm7GVrQJgygVp5xrSOixW gDtHSPdrQnfqSPGCUs9crDzyA5P77qCi0pYULDwO+4l/UNW6zU6r3yM2amjpPvK2GOiG Gzyq27yRZhOvTd9yRYuyI8lEnkN8Tr0I+ayf2gnp+YBLrLJlFnTApP91LDbhFqjUUet7 tiHerycM7g19mzYregs+tnn16eHbVNDrB/9FqoueFKnSoKWBYQRnqHmTaGZuY+L7+0VK Lt9t/ndiAQSeKWfDbNES/FIvG11bgnUPrHKivfZntyOo94HqL8A9Re4ctfsATcKSwDNK MNIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HNRrH6pVFd2ShQx69BQENhHFCRJ2DJdc/TbT0vWDWBA=; b=zbfxQBdwCITKeJkngE0ql+jqJnbVR7pCY1J6P2pcygTn8VtDyfZ0z3vDcJOHQAEdz2 ifXv8wRabFcknkh1rUKhLEwbIkdgw+w1HCsn4zTCkuwPVYiEGyvvPzDItcUHdiSG//kT tA17LrZfeA/XYwMjJy48Bgf4GD/EYUC3qhkxCMrb8HMNVpqxEnUSdj+HELWAMVAKGV7F vrJvyJ5tB57FTcPIPaI0AStPyNSveKbf1F6Nd6u6ORhR40gmTs0MN6OTS3kWh9ptrDVq vwpMzxVOOMNzlWi+0dY8LNhOPd5ZesNWC3kC9pcr619DEKQxL0DOdiH1vTosLFajFqDe l+Ew== X-Gm-Message-State: AO0yUKXtWA61LNk/AwwP0U1fVmRSMc7Xgi0mqDJNJ90n9Z4K0BN7HQkm NQlpaTHJ8Snf89QB7fhdL5bObw== X-Google-Smtp-Source: AK7set9EKm+ljNDXO8rry/RYjZUYrLXSN+ZaRUUJFfk9J3sel0OVnXraCoS/B6pbcDZ/GaRn+sG7Tg== X-Received: by 2002:adf:fcc1:0:b0:2c3:f78f:518f with SMTP id f1-20020adffcc1000000b002c3f78f518fmr18003290wrs.39.1676285958566; Mon, 13 Feb 2023 02:59:18 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h12-20020adff4cc000000b002be505ab59asm10354062wrp.97.2023.02.13.02.59.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 02:59:18 -0800 (PST) Message-ID: <10ddd574-3ad1-f2e7-e7b4-a6803ee240d6@linaro.org> Date: Mon, 13 Feb 2023 11:59:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/6] dt-bindings: soc: amlogic: document System Control registers Content-Language: en-US To: Neil Armstrong , Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Michael Turquette , Stephen Boyd Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20230209-b4-amlogic-bindings-convert-take2-v1-0-c4fe9049def9@linaro.org> <20230209-b4-amlogic-bindings-convert-take2-v1-3-c4fe9049def9@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230209-b4-amlogic-bindings-convert-take2-v1-3-c4fe9049def9@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_025927_918245_55F2B33A X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/02/2023 14:41, Neil Armstrong wrote: > Document the System Control registers regions found on all Amlogic > SoC families and it's clock, power, pinctrl and phy subnodes. > > The regions has various independent registers tied to other > hardware devices, thus the syscon compatible. > > Clock controllers and Pinctrl devices are not yet documented, the > definition of those will be updated in a second time. > > Signed-off-by: Neil Armstrong > --- > .../soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml | 109 +++++++++++++++++++++ > 1 file changed, 109 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > new file mode 100644 > index 000000000000..672eabd90c09 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Meson System Control registers > + > +maintainers: > + - Neil Armstrong > + > +properties: > + compatible: > + items: > + - enum: > + - amlogic,meson-gx-hhi-sysctrl > + - amlogic,meson-gx-ao-sysctrl > + - amlogic,meson-axg-hhi-sysctrl > + - amlogic,meson-axg-ao-sysctrl > + - const: simple-mfd > + - const: syscon > + > + reg: > + maxItems: 1 > + > + clock-controller: > + type: object > + > + power-controller: > + $ref: /schemas/power/amlogic,meson-ee-pwrc.yaml > + > + pinctrl: > + type: object > + > + phy: > + type: object > + > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - amlogic,meson-gx-hhi-sysctrl > + - amlogic,meson-axg-hhi-sysctrl > + then: > + required: > + - power-controller > + > + - if: > + properties: > + compatible: > + enum: > + - amlogic,meson-gx-ao-sysctrl > + - amlogic,meson-axg-ao-sysctrl > + then: > + required: > + - pinctrl > + > + - if: > + properties: > + compatible: > + enum: > + - amlogic,meson-axg-hhi-sysctrl > + then: > + properties: > + phy: > + oneOf: > + - $ref: /schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml > + - $ref: /schemas/phy/amlogic,meson-axg-mipi-pcie-analog.yaml And all other variants? This allows phy/power/pinctrl/clock in any combination, thus maybe the binding should be just split? Hard to say without full picture. > + > +required: > + - compatible > + - reg > + - clock-controller > + > +unevaluatedProperties: false > + > +examples: > + - | > + sysctrl: system-controller@0 { > + compatible = "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"; > + reg = <0 0x400>; > + > + clock-controller { }; The example should be complete, so empty node does not look correct. If you wait for other bindings, send them as patchset when all are ready. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel