From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF847C5478A for ; Wed, 21 Feb 2024 17:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AXdaS1UUnn5h+Es/hyUAbn49Gh6XqfKSZJ3vS/CbpMA=; b=NBU1EHOFvor1qw k1RNeLAECK9D11t4fdPm4i3Jz/UioE6xqPKBhW7Ye9Lty6zyQ3qv5gytxLziH6/AqKFGKog+9b/N/ x+EoK7Vd8B5BzicPhouyu/pkQbQFhtSSRKB+b/1OFAVvBUdrOkZVXjn4i4DbYT4Q05U+ozpvoQ+nu U+BHRPuW1DN0QO924PsM3lqfLaJFcmu3KaPC/gEZfYuNAaoAvjT3AqJXFaAzKgiPPP40yQKOzoDgU bOWL4CSpEA3X0IH05yjGEwR0p0pduq6c+DNqYyfFXkP+Lhm+9VLrMjNR/WXAhTiHlIUxe0wPq6gVc wBw+gzjpFH2zP4fMRC+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcqpY-00000001zoo-0Hy0; Wed, 21 Feb 2024 17:56:28 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcqpV-00000001zmV-1KMH for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 17:56:26 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-55f50cf2021so1471640a12.1 for ; Wed, 21 Feb 2024 09:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708538179; x=1709142979; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=it/RVOfJK4MjxrALV/dDH3SHkP5fEcXIOdKDJod6bwg=; b=CIh6HMRj+Y2N+DxtaKvo3m6zJGuBu79mlDnTD3hwILpmA8I6qsk2mg3aIYcDouyCCx PlpPyxvmTsgqtTGQlDCRsUkqY3eaMtqxdj/DAAFjlbekNXLkFpwlgoAeWn0yXImvwOTW fHEgDyMHy6CC/RgZ9W0etCr+kOshFL2RX3F5DMoC8XJbDSt/1AMHbAD/mWjmeWEw2tPL dxCPHAbT2BRvMJlul93Lr4yV+aAyuOrVrdVsqYl68FeLlp857IG7diy2R6xM4kClxREX Osg7jzHmIdi+gqKpsBIuBs9oXmgjldEh969NGl8ukj0YUspx0ag0Ws3FT90X/GwyYJld 8LJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708538179; x=1709142979; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=it/RVOfJK4MjxrALV/dDH3SHkP5fEcXIOdKDJod6bwg=; b=lNrT4G8l49Mx8itsTfj9wqDAmJxf8rPe9yb03sKy4xeXK43BEaMmPNfXTW1Qb50ES7 zQZZcTWX0mFigmodBgyY0PzD9eMTK67jqu/stzfrEM6iJ1mQx4qtWPpIr+EknpfVsNX7 gOHlyDJD38d3WhJRmAiR81X80Y4K5J2vkcUM+M3xYJV32fhIrUGFXgHoztw7c6BGQumQ LkuFI6dvZhlm0suxCCUwm0G/+YRFABHEnlQUEfD0VACk6Hy92liKvW2Lo1KIQLbdG4xH /ZP/DKhYZGAaQlVbdNQgnNiEItg/zkvhGBkY6CvdqU5ipzSC8TUoZ4pNeDL7OmUlOMod ktaA== X-Forwarded-Encrypted: i=1; AJvYcCV9dMJV0qo4wsTWc5cOLIxghiNtfAWGOyPKEnJeDJcvXKKMZzmKdTipAbysboGhVFIv7Lv9AKB1XfYqsclLUM3ZK2i9ugvl3at8DjpQvoaF2+E3D3I= X-Gm-Message-State: AOJu0YzVeLPkDlGxhWCcH+NOvMPcTwRuIgLWAWOCzLPhtsYPrymiA3NE 6l+xjNO8Av+2r+TURuxSmpIYRsD6OGApxxDQP5r3E07IARyoigddZZsBHjYdzBM3QgpEDc42HOF 0 X-Google-Smtp-Source: AGHT+IGqE47uiLD78T1yQU2qNPN6dVRDsaT5Rxu1kmz28dCgLQ7tsFftgT+1AISRebYrTKMrx/S7WA== X-Received: by 2002:a17:906:b094:b0:a3c:a4ba:7917 with SMTP id x20-20020a170906b09400b00a3ca4ba7917mr11807476ejy.0.1708538179316; Wed, 21 Feb 2024 09:56:19 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id qo3-20020a170907874300b00a3e4efbfdacsm4234766ejc.225.2024.02.21.09.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 09:56:18 -0800 (PST) Message-ID: <10f692ae-ac7a-4243-aadc-80712f781d39@linaro.org> Date: Wed, 21 Feb 2024 17:56:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/12] spi: s3c64xx: switch exynos850 to new port config data Content-Language: en-US To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, semen.protsenko@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org References: <20240216070555.2483977-1-tudor.ambarus@linaro.org> <20240216070555.2483977-13-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: <20240216070555.2483977-13-tudor.ambarus@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_095625_392524_F62EC584 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey, Sam, On 2/16/24 07:05, Tudor Ambarus wrote: > Exynos850 has the same version of USI SPI (v2.1) as GS101. I tested GS101 and it worked, I guess exynos850 SPI shall work too as it uses the same SPI version, v2.1. Can you run a test on your side too see if works? If not, Mark can drop this patch I guess. Please let us know your preference. Cheers, ta > Drop the fifo_lvl_mask and rx_lvl_offset and switch to the new port > config data. > > Backward compatibility with DT is not broken because when alises are > set: > - the SPI core will set the bus number according to the alias ID > - the FIFO depth is always the same size for exynos850 (64 bytes) no > matter the alias ID number. > > Advantages of the change: > - drop dependency on the OF alias ID. > - FIFO depth is inferred from the compatible. Exynos850 integrates 3 SPI > IPs, all with 64 bytes FIFO depths. > - use full mask for SPI_STATUS.{RX, TX}_FIFO_LVL fields. Using partial > masks is misleading and can hide problems of the driver logic. > > Just compiled tested. > > Signed-off-by: Tudor Ambarus > --- > drivers/spi/spi-s3c64xx.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 784786407d2e..9fcbe040cb2f 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -1576,10 +1576,9 @@ static const struct s3c64xx_spi_port_config exynos5433_spi_port_config = { > }; > > static const struct s3c64xx_spi_port_config exynos850_spi_port_config = { > - /* fifo_lvl_mask is deprecated. Use {rx, tx}_fifomask instead. */ > - .fifo_lvl_mask = { 0x7f, 0x7f, 0x7f }, > - /* rx_lvl_offset is deprecated. Use {rx, tx}_fifomask instead. */ > - .rx_lvl_offset = 15, > + .fifo_depth = 64, > + .rx_fifomask = S3C64XX_SPI_ST_RX_FIFO_RDY_V2, > + .tx_fifomask = S3C64XX_SPI_ST_TX_FIFO_RDY_V2, > .tx_st_done = 25, > .clk_div = 4, > .high_speed = true, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel