From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29D08C433EF for ; Sat, 18 Jun 2022 01:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8FxMOd9M7QxGnJgmBiqJzQhh7qV5UIkgAKlX3fPTgsE=; b=KjjvQlxJnXzKJL WjMiMxdeTEoYRhMyU9AbcrHE+E/UJTqJ7RItzlWHxzYVMqnIh9LEmaCP2zVeb4Y2BWZDPUtaFb36/ dOfKRY27C6w7xGPlM0LQ8siS0K00iYZCpZKO0H0CM6ZvrXiZTakLDGmIsmgV9ImJTwfvDaVrzoJLi dPmk7B4zFTDfZwVt4V5Y7fQsSwyf7N1LL7wxBol1CkIwECPu4o2hGgK5B9WZrwxVBQeP7blB5wpnf Hay4rNxAAD2n2pv6rk0jZFOeR6OdMtVCaXmvO/+baFjxgnovQTiNaDLm7RqBsrwf4ja6MixDQ81PN VLZxMascRnBybaD5pU9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2N4A-009shV-5S; Sat, 18 Jun 2022 01:15:58 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2N44-009sf0-RC for linux-arm-kernel@lists.infradead.org; Sat, 18 Jun 2022 01:15:56 +0000 Received: by mail-pg1-x535.google.com with SMTP id e63so3880357pgc.5 for ; Fri, 17 Jun 2022 18:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2Wicin66A5Ecw5eOHjSRw3gMf1e/v5xlB1s6rjFamVc=; b=rYxYQNnXCvLE4VkDuRntdBWtvRSy9Js0aFg2p7PC8AoRXwLqSP/VcXnFUB041aQM+Z Cr32BoNciIvWFGPNqDnK7+dLMMiii0j195J6SfzP5gqj+Th7Syj3gV9xjSTrjk4+j52R BuE485MDS3716u/H6iFT3/P7PmXu6SrRQOU/y23CI6AVDiBqO7tAzKdifXQehVcLPo+I 4m/+uEHjUP4jyYxWVeBvHRwSxbGmHC3qJFDf0ZZfqCzJfPIXbdMlri+ZiC+3s3gMOG/U LrKqhRMR6EBTErEj1BmuWVGdvRiyLkpO4q/mbpMCGH5UY1Zl5qKSfMEGbolQniYIOl/9 5+pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2Wicin66A5Ecw5eOHjSRw3gMf1e/v5xlB1s6rjFamVc=; b=FVyFeHBwtYrIYawFqPMkruKxq/1Cf3ktnDz74LO8Kxow6P8nHOGhoL93r9BtJW685F icAkCZdwL0DNWFC5aQaJn9M5oP4xDtrmYmfm8ayxaM51TMuORdm+w3mwg+jnh6YaimuC W13EbU8YDqR8aZPUJ8qHj+TKWgGKRJr4RLmsFleW5bxOGjyEBJJM1SqAIyvfB1kQUIYF TPpNJPkddv51ZAQnzUL9QV2isA1RO7zvXnoHU5MHeGql+my/X7IENgnYD/Zp9BfC8N3V EShrGuoXFBGVSGMjp0ZBYOrKQUAeG2sag6TftbpPxsAyE0q8+Rg6IwvKVHk7zQ+WK2A5 zoqA== X-Gm-Message-State: AJIora90SYQTng49ZWJowTwYDo9/YeOK5WkjFuILR+gt5pOZW1ilhcmo KkszoJTIBRtUsxaqFvmYToLNJA== X-Google-Smtp-Source: AGRyM1u5MsCZ5unrFNNSkRvF2SL6LwoHOZByCaW9oeRdELC6PITpnSRHbGHN4xDSAWSCZtviQKdPpg== X-Received: by 2002:a63:6c42:0:b0:3fe:465:7a71 with SMTP id h63-20020a636c42000000b003fe04657a71mr11328301pgc.101.1655514950870; Fri, 17 Jun 2022 18:15:50 -0700 (PDT) Received: from [172.31.235.92] ([216.9.110.6]) by smtp.gmail.com with ESMTPSA id o1-20020a62f901000000b0052285857864sm4410468pfh.97.2022.06.17.18.15.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 18:15:50 -0700 (PDT) Message-ID: <110c4a4b-8007-1826-ee27-02eaedd22d8f@linaro.org> Date: Fri, 17 Jun 2022 18:15:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH net-next 01/28] dt-bindings: phy: Add QorIQ SerDes binding Content-Language: en-US To: Sean Anderson , "David S . Miller" , Jakub Kicinski , Madalin Bucur , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Paolo Abeni , Russell King , Eric Dumazet , Kishon Vijay Abraham I , Krzysztof Kozlowski , Rob Herring , Vinod Koul , devicetree@vger.kernel.org, linux-phy@lists.infradead.org References: <20220617203312.3799646-1-sean.anderson@seco.com> <20220617203312.3799646-2-sean.anderson@seco.com> From: Krzysztof Kozlowski In-Reply-To: <20220617203312.3799646-2-sean.anderson@seco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_181553_015350_1A1AF7EB X-CRM114-Status: GOOD ( 34.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/06/2022 13:32, Sean Anderson wrote: > This adds a binding for the SerDes module found on QorIQ processors. The > phy reference has two cells, one for the first lane and one for the > last. This should allow for good support of multi-lane protocols when > (if) they are added. There is no protocol option, because the driver is > designed to be able to completely reconfigure lanes at runtime. > Generally, the phy consumer can select the appropriate protocol using > set_mode. For the most part there is only one protocol controller > (consumer) per lane/protocol combination. The exception to this is the > B4860 processor, which has some lanes which can be connected to > multiple MACs. For that processor, I anticipate the easiest way to > resolve this will be to add an additional cell with a "protocol > controller instance" property. > > Each serdes has a unique set of supported protocols (and lanes). The > support matrix is stored in the driver and is selected based on the > compatible string. It is anticipated that a new compatible string will > need to be added for each serdes on each SoC that drivers support is > added for. > > There are two PLLs, each of which can be used as the master clock for > each lane. Each PLL has its own reference. For the moment they are > required, because it simplifies the driver implementation. Absent > reference clocks can be modeled by a fixed-clock with a rate of 0. > > Signed-off-by: Sean Anderson > --- > > .../bindings/phy/fsl,qoriq-serdes.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/fsl,qoriq-serdes.yaml > > diff --git a/Documentation/devicetree/bindings/phy/fsl,qoriq-serdes.yaml b/Documentation/devicetree/bindings/phy/fsl,qoriq-serdes.yaml > new file mode 100644 > index 000000000000..4b9c1fcdab10 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/fsl,qoriq-serdes.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/fsl,qoriq-serdes.yaml# File name: fsl,ls1046a-serdes.yaml > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP QorIQ SerDes Device Tree Bindings s/Device Tree Bindings// > + > +maintainers: > + - Sean Anderson > + > +description: | > + This binding describes the SerDes devices found in NXP's QorIQ line of Describe the device, not the binding, so wording "This binding" is not appropriate. > + processors. The SerDes provides up to eight lanes. Each lane may be > + configured individually, or may be combined with adjacent lanes for a > + multi-lane protocol. The SerDes supports a variety of protocols, including up > + to 10G Ethernet, PCIe, SATA, and others. The specific protocols supported for > + each lane depend on the particular SoC. > + > +properties: Compatible goes first. > + "#phy-cells": > + const: 2 > + description: | > + The cells contain the following arguments. > + > + - description: | Not a correct schema. What is this "- description" attached to? There is no items here... > + The first lane in the group. Lanes are numbered based on the register > + offsets, not the I/O ports. This corresponds to the letter-based > + ("Lane A") naming scheme, and not the number-based ("Lane 0") naming > + scheme. On most SoCs, "Lane A" is "Lane 0", but not always. > + minimum: 0 > + maximum: 7 > + - description: | > + Last lane. For single-lane protocols, this should be the same as the > + first lane. > + minimum: 0 > + maximum: 7 > + > + compatible: > + enum: > + - fsl,ls1046a-serdes-1 > + - fsl,ls1046a-serdes-2 Does not look like proper compatible and your explanation from commit msg did not help me. What "1" and "2" stand for? Usually compatibles cannot have some arbitrary properties encoded. > + > + clocks: > + minItems: 2 No need for minItems. > + maxItems: 2 > + description: | > + Clock for each PLL reference clock input. > + > + clock-names: > + minItems: 2 > + maxItems: 2 > + items: > + pattern: "^ref[0-1]$" No, instead describe actual items with "const". See other examples. > + > + reg: > + maxItems: 1 > + > +required: > + - "#phy-cells" > + - compatible > + - clocks > + - clock-names > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + serdes1: phy@1ea0000 { > + #phy-cells = <2>; > + compatible = "fsl,ls1046a-serdes-1"; > + reg = <0x0 0x1ea0000 0x0 0x2000>; > + clocks = <&clk_100mhz>, <&clk_156mhz>; > + clock-names = "ref0", "ref1"; > + }; > + > +... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel