Re: [PATCH v1 3/5] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3568

Johan Jonker
2021-04-21T09:29:00Z

On 4/21/21 8:59 AM, cl@rock-chips.com wrote:
> From: Liang Chen <cl@rock-chips.com>
>
> add "rockchip,rk3568-dwcmshc", "snps,dwcmshc-sdhci" for mmc nodes on
> a rk3568 platform to rockchip-dw-mshc.yaml.
>
> Signed-off-by: Liang Chen <cl@rock-chips.com>
> ---
> Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> index 3762f1c8de96..2a6c1cee4887 100644
> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> @@ -27,6 +27,8 @@ properties:
> - const: rockchip,rk2928-dw-mshc
> # for Rockchip RK3288
> - const: rockchip,rk3288-dw-mshc

> + # for Rockchip RK3568
> + - const: rockchip,rk3568-dwcmshc

Remove.
This would create two descriptions.
"rockchip,rk3568-dwcmshc"
"rockchip,rk3568-dwcmshc", "snps,dwcmshc-sdhci"

> - items:
> - enum:

> # for Rockchip PX30

Remove comments.

> @@ -41,6 +43,8 @@ properties:
> - rockchip,rk3328-dw-mshc

> # for Rockchip RK3368

Remove comments.

> - rockchip,rk3368-dw-mshc

> + # for Rockchip RK3568

Maybe remove the "#" comments in this enum part too.
This was one of the first Rockchip documents that was converted, but is
not really needed, as it both mentions the soc name.

> + - rockchip,rk3568-dw-mshc

Sort this below rockchip,rk3399-dw-mshc

> # for Rockchip RK3399

Remove comments.
> - rockchip,rk3399-dw-mshc

> # for Rockchip RV1108

Remove comments.