From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] ARM: EXYNOS: Allow to use architected timer
Date: Tue, 06 Oct 2015 12:03:09 +0200 [thread overview]
Message-ID: <11155544.mMhEXg27TI@wuerfel> (raw)
In-Reply-To: <00e901d1001b$a7fae610$f7f0b230$@samsung.com>
On Tuesday 06 October 2015 12:44:54 Pavel Fedin wrote:
> Hello!
>
> > My feeling is that is shouldn't be keyed off the presence of the device in DT
> > though. Maybe we can find a way that allows you to put the device into DT
> > but not have it used by default unless the user explicitly enables it, e.g. though
> > a kernel command line option like "force_broken_archtimer"?
>
> For this purpose we have status = "disabled" in the device tree. We can add CP15 timer node and
> disable it. If the user needs it, the bootloader could just change "disabled" to "ok", and it's
> done.
> The only problem here would be that CP15 timer on Exynos is actually tied to MCT. We need to enable
> MCT, otherwise clocks don't tick. That's why i decided to make CP15 timer a subnode.
> My current patch lacks "status" property check, i could add it if you agree with this approach.
It's not ideal, because the hardware is always there and always slightly
broken, so it's not really a property of the platform. I'd be happier with
something that is easier for users to change if they know what they are
doing and also makes it clear that it is slightly risky.
> > Or maybe we could find a way to keep using MCT in the host but use the
> > arch timer in the guest only?
>
> That's an interesting question, but, perhaps, it would require more changes to the code, and KVM
> maintainers don't like these things, calling them "broken non-compliant hardware". So, i guess, we
> could move from simple things to more complex ones.
It's probably worth trying to see how much complexity you need for that
approach, maybe it's not as hard in the end.
> > For all I can tell, nobody every /saw/ the problem, we just know that it
> > hasn't passed verification (or something like that) and you shouldn't
> > use it in production.
>
> Yes, and i agreed that this should be an option, not the default.
>
> P.S. I cc'ed to linux-samsung-soc, but i'm not subscribed. Will it reach there?
I think it should, at least I didn't get an email back for my reply,
and I'm not subscribed either.
Arnd
next prev parent reply other threads:[~2015-10-06 10:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 8:23 [PATCH 0/2] ARM: EXYNOS: Allow to use architected timer Pavel Fedin
2015-10-06 8:23 ` [PATCH 1/2] exynos_mct: Allow to use architected timer mode Pavel Fedin
2015-10-06 8:24 ` [PATCH 2/2] ARM: dts: Use architected timer on Exynos 5410 Pavel Fedin
2015-10-06 8:33 ` Chanwoo Choi
2015-10-06 8:49 ` Pavel Fedin
2015-10-06 8:37 ` [PATCH 0/2] ARM: EXYNOS: Allow to use architected timer Arnd Bergmann
2015-10-06 8:51 ` Alexey Klimov
2015-10-06 8:56 ` Pavel Fedin
2015-10-06 9:12 ` Arnd Bergmann
2015-10-06 9:44 ` Pavel Fedin
2015-10-06 10:03 ` Arnd Bergmann [this message]
2015-10-06 10:09 ` Kukjin Kim
2015-10-06 10:16 ` Pavel Fedin
2015-10-06 10:25 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11155544.mMhEXg27TI@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox