From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 03 Oct 2011 15:43:10 +0200 Subject: [PATCH 5/6] ASoC: samsung: wm8994 depends on mfd_wm8994 In-Reply-To: <20111003120741.GD23811@sirena.org.uk> References: <1317587284-2776-1-git-send-email-arnd@arndb.de> <1869072.QQLATNzYYx@wuerfel> <20111003120741.GD23811@sirena.org.uk> Message-ID: <11174515.ANsqIhx0NX@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Any driver that selects SND_SOC_WM8994 should also make sure that MFD_WM8994 is set, since the codec relies on the mfd code: sound/built-in.o: In function `wm8994_read': last.c:(.text+0x20160): undefined reference to `wm8994_reg_read' sound/built-in.o: In function `wm8994_write': last.c:(.text+0x20e68): undefined reference to `wm8994_reg_write' This adds the missing 'depends' statements to Kconfig, as found during ARM randconfig tests. Signed-off-by: Arnd Bergmann --- sound/soc/samsung/Kconfig | 3 +++ 1 file changed, 3 insertions(+) On Monday 03 October 2011 13:07:41 Mark Brown wrote: > On Mon, Oct 03, 2011 at 01:50:08PM +0200, Arnd Bergmann wrote: > > > the patch. The other problem in this patch is still there, with > > CONFIG_SND_SOC_SMDK_WM8994_PCM=y and CONFIG_MFD_WM8994=n: > > You've not sent a seprate patch for that one yet... I wasn't sure any more which version you wanted. Is this this right one? --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -65,6 +65,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580 config SND_SOC_SAMSUNG_SMDK_WM8994 tristate "SoC I2S Audio support for WM8994 on SMDK" depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210) + depends on MFD_WM8994 select SND_SOC_WM8994 select SND_SAMSUNG_I2S help @@ -152,6 +153,7 @@ config SND_SOC_GONI_AQUILA_WM8994 tristate "SoC I2S Audio support for AQUILA/GONI - WM8994" depends on SND_SOC_SAMSUNG && (MACH_GONI || MACH_AQUILA) select SND_SAMSUNG_I2S + depends on MFD_WM8994 select SND_SOC_WM8994 help Say Y if you want to add support for SoC audio on goni or aquila @@ -175,6 +177,7 @@ config SND_SOC_SMDK_WM8580_PCM config SND_SOC_SMDK_WM8994_PCM tristate "SoC PCM Audio support for WM8994 on SMDK" depends on SND_SOC_SAMSUNG && (MACH_SMDKC210 || MACH_SMDKV310) + depends on MFD_WM8994 select SND_SOC_WM8994 select SND_SAMSUNG_PCM help