From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: 3.20-rc0 breaks nfsroot over usb
Date: Fri, 27 Feb 2015 21:06:37 +0100 [thread overview]
Message-ID: <11261945.VmGdV7ZTh2@wuerfel> (raw)
In-Reply-To: <20150227153809.GS11056@atomide.com>
On Friday 27 February 2015 07:38:09 Tony Lindgren wrote:
> * Aaro Koskinen <aaro.koskinen@iki.fi> [150226 15:06]:
> > Hi,
> >
> > On Thu, Feb 26, 2015 at 11:19:50PM +0100, Pavel Machek wrote:
> > > Ok, it seems that new config dependencies broke my kconfig. These will
> > > not be enabled if you just to make oldconfig; you want to make sure
> > > they are on.
> > >
> > > OMAP2430 and onwards (USB_MUSB_OMAP2PLUS) [N/m/y] (NEW)
> > > TWL4030 USB Transceiver Driver (TWL4030_USB) [N/m/y/?] (NEW)
> >
> > Yes, also other users have reported "USB breakage" with 4.0-rc1 on N900
> > etc caused by this.
> >
> > Commit fbba7db3990cb707ff91cd6507d53a0a730afe97 (usb: musb:
> > add omap-control dependency) changed USB_MUSB_OMAP2PLUS to depend
> > on OMAP_CONTROL_PHY but that seems to be wrong at least for OMAP3.
> > omap_control_phy.h provides dummy functions when it's not enabled.
> > So there should be no dependency.
The problem I fixed was a link error when USB_MUSB_OMAP2PLUS
is built-in but OMAP_CONTROL_PHY is a loadable module.
> I guess the solution would be to make drivers/phy handle whatever
> omap_control_usb_set_mode is doing in a generic way.
I'm very sorry about the breakage in a patch that is marked for
backports.
Please accept my apology and the workaround patch in the
follow-up mail.
Arnd
next prev parent reply other threads:[~2015-02-27 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 18:55 3.20-rc0 breaks nfsroot over usb Pavel Machek
2015-02-26 22:19 ` Pavel Machek
2015-02-26 23:03 ` Aaro Koskinen
2015-02-27 15:38 ` Tony Lindgren
2015-02-27 20:06 ` Arnd Bergmann [this message]
2015-02-27 20:12 ` [PATCH] usb: musb: fix Kconfig regression Arnd Bergmann
2015-02-27 20:21 ` Felipe Balbi
2015-02-27 22:56 ` Pavel Machek
2015-02-27 19:14 ` 3.20-rc0 breaks nfsroot over usb Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11261945.VmGdV7ZTh2@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox