Re: [PATCH] arm64: dts: rockchip: enable SD UHS-I on Firefly-RK3399

["Heiko Stübner" <heiko@sntech.de>]

Hi,

Am Sonntag, 1. November 2026, 16:44:07 Mitteleuropäische Normalzeit schrieb Yaozhong Li:
> Hi Heiko,
> 
> Gentle ping on this one. It still applies cleanly to current mainline.
> Please let me know if you would like anything changed.

to change would be the the commit message, it is way too verbose and
quite confusing.

Also as can be seen in wifi-module datasheets, they seem to call their
main supply " VBAT - Main power voltage source input", which is
vcc3v3_sys on the firefly, so the sdio block should get an appropriate
vmmc-supply too.

The gist for a commit message as I currently get it would be like:

======
Contrary to the naming, vcc-sdio is actually the io-supply routed to the
sdmmc controller - as can be seen in the schematics.

The schematics also show the wifi block's VBAT main input source coming
from VCC3V3_SYS and it's io-supply is the already correct vcc_1v8_s3
although the datesheet is mixing namings up a bit.

Adapt the supplies for sdmmc0 and sdio accordingly and enable the sdr104
UHS mode that now becomes possible

With UHS enabled sequential read goes from 22 MB/s to 60 MB/s with a
64GB SDXC card. WiFi remained associated at 5 GHz, -50 dBm, with no
kernel errors.
======

includes adding the correct sdio vmmc-supply.

Heiko