From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 429ABC3DA6E for ; Fri, 5 Jan 2024 14:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PR+PJhf/5NMEAFo0r/Nos9TUNO2CuBhsS3S2/9uVq70=; b=Mhacdw658iBHFY 1h4AmDPTyRpmA8WV0iAgz8y/vyapTyYcebxqohlTDmGiNXRpA5PMnGDgq9mAIdd5XV7wSu+NlYfC2 UKb3aKcLR5hER60OMgGXn6dW0vC4pdQiK05G+ljAqQFo2kdLnu8MY2nmozwqRB8uzz16iBVi3KpYO sjJmLkp/5IPTbqc79CXeQ5HpbSMYViUGEkwBL1gl9I08Clov66Xk42t1fMXt458U5mOKW0F6UMgFR GCnkiLpUQtCsbDJWNo8xCZtv6odmVjA0lNzb66IUBXpgc4k4k9TPcPwWGIvESCE7ouxJ94rcCwU5/ J8BPek4vs4BGf+h+lvUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLlLf-00H5Si-0B; Fri, 05 Jan 2024 14:38:59 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLlLb-00H5RM-2I for linux-arm-kernel@lists.infradead.org; Fri, 05 Jan 2024 14:38:57 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EFAA75C0231; Fri, 5 Jan 2024 09:38:49 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 05 Jan 2024 09:38:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1704465529; x=1704551929; bh=PuOOcZVM21 gvZ/ZF8zREl/JKU6SeL7edQiXakF+8FHU=; b=AQt5b4TjoaXbIqqk+EIOMW3nQF 1OcKuXI4BGV7jzrmJthiTnnHKnrKWuceIG0GdPIcS7Mcm9IPXB0rMoVzzcu4UDLa D7QPJeYD43bo/oxgA8TGSw9DNPq8yl4UMdjYTwd0YqIF+adIS8bgsISYYkFrIig8 ul4YIeGGqb4gFapfgO4elo/XaE8GNwL7FJMstTFsZqPea6xkB/s5TNhnyUGaAuyP ld/qZ58QjkR6Bo9hEanLlGyjIiQM/4yp7RPCt/cPAI+kud6izBfyHBHujjN8oe6J fvZ+2AbNFS5/e9baqyhG0y50v50OGZ7Fb1j3bNmcqLzJL1kGhaUGP9mTm/4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1704465529; x=1704551929; bh=PuOOcZVM21gvZ/ZF8zREl/JKU6Se L7edQiXakF+8FHU=; b=4r1fPsMF4dW2iF6HVH/EQsinrQBd693Tq0Sj/tdhj+lb AFEkVyANLWrneduMVfeiIU740wFd1SXM/NuhC3LaUtGUUGi9k5AfnRWOkGgCFZdZ 7ceeYow6GXMi5i2QRaUCkXFodAdjJmtJEsmuVUS4JnLATyj9/DJ5CbQ+tQhF8GV7 wHVzDaRyo7w03GWZ9y4O9MZfenMrk+qxIhey+qSDEL2fHfHxsQZB0vLeUpi53wzT kj4mNaqi2Y8hMWLVawdAzmFLvVbfM2qifM9D7RXfcWcVrbbM86znvoUFWs892/WS maLObG1REGIqR3sw0TDyW1xJMa+rekwLtG5c62yhlQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdegledgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5FB43B6008F; Fri, 5 Jan 2024 09:38:49 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1364-ga51d5fd3b7-fm-20231219.001-ga51d5fd3 MIME-Version: 1.0 Message-Id: <112ae7d5-61b2-4887-a56f-35ea7c3b1bfa@app.fastmail.com> In-Reply-To: References: <20240105041458.126602-3-leobras@redhat.com> Date: Fri, 05 Jan 2024 15:38:05 +0100 From: "Arnd Bergmann" To: "Mark Rutland" , "Leonardo Bras" Cc: "Oleg Nesterov" , "Catalin Marinas" , "Will Deacon" , "Mark Brown" , "Steven Rostedt" , "Guo Hui" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] arm64: remove unnecessary ifdefs around is_compat_task() X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240105_063856_108057_0126A089 X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 5, 2024, at 14:14, Mark Rutland wrote: > On Fri, Jan 05, 2024 at 01:15:00AM -0300, Leonardo Bras wrote: > arch/arm64/kernel/ptrace.c:2121:25: note: each undeclared identifier is > reported only once for each function it appears in > arch/arm64/kernel/ptrace.c:2123:25: error: 'user_aarch32_ptrace_view' > undeclared (first use in this function) > 2123 | return &user_aarch32_ptrace_view; > | ^~~~~~~~~~~~~~~~~~~~~~~~ > make[4]: *** [scripts/Makefile.build:243: arch/arm64/kernel/ptrace.o] > Error 1 > make[3]: *** [scripts/Makefile.build:480: arch/arm64/kernel] Error 2 > make[2]: *** [scripts/Makefile.build:480: arch/arm64] Error 2 > make[1]: *** [/home/mark/src/linux/Makefile:1911: .] Error 2 > make: *** [Makefile:234: __sub-make] Error 2 > > ... and looking at the code, user_aarch32_view and user_aarch32_ptrace_view are > both defined under ifdeffery for CONFIG_COMPAT, so that's obviously not going > to work... I suspect it's enough to remove all of the other "#ifdef CONFIG_COMPAT" checks in this file and rely on dead code elimination to remove the rest, but there might be additional problems if some extern declarations are hidden in an #ifdef as well. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel