From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 008A8CD1284 for ; Tue, 9 Apr 2024 05:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kB7fZ7tj8AsB7Kmnuw3IbJ694/rNqwDmOjA++IzYtRM=; b=R+kyACHqEFllyC rtIwUCoTrZuArdcwWaOZs1fzuecwX6Ax41cbjmLzzAoEMRsOP/LeOChEok5nvbj7hvYXCh1giLiYk jy4L1nXR4/2CiPIfkmpvQOS5RtSzFVeZtqzTPtnzcJ/I+9YA0wSsIFX2St+NcFmsuiDlGQJDJ4Klj WSl6t4yMI5+19HgXDI/JUKQttLOz46dvlTdBIusCPBfukVHdjsjTFLUXLFYRL+6uiGPiGyfQMAzxv fpgAlqtGGYT/FjEwhclDobVOIOxsH4W2dvVLSqAB2BHYfKJMbKTxwt/XOHAhhh7PQHTZURdpygmuD hDiyGj7ULA+53lRN1bgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru424-00000000QJY-1HAW; Tue, 09 Apr 2024 05:28:32 +0000 Received: from mail-108-mta186.mxroute.com ([136.175.108.186]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru422-00000000QIn-1557 for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 05:28:31 +0000 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta186.mxroute.com (ZoneMTA) with ESMTPSA id 18ec14f805f0003bea.009 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 09 Apr 2024 05:23:16 +0000 X-Zone-Loop: 8d22fbf9b9ea2bc37cd2e68f2ec56dfed0c57e05e9d6 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E4MKkW6f1nSRZdtxgNHT1iqRYe28mUV0vTu6PYIA7AU=; b=IAFTK/4qWYzi0uoH+gzXRH277M szUC1vHKbVHJD93VaP8lYVj7chkg2INkU9P3Twn8j5bvPr5tLsgB39GExHcDqmi5eL/twM0E7zQAa vOEsfdAFAlJGt2o5IfIXHXi6t9iN4G4MYhCNas1emwK2+Yl7qHV746HCf8kvAUg1/FLR0v7UsAqdv S577OjtwYuYwhlvxIoQkcQfdV1Ti5wFJ8aj3UEsBF8dn6r810HgKxE9nepl3ikqGR528RMTdRVm1P M06VNj0ujBzCTMxqBnKEzgIJoc+oiTKaSkde7FVqhN0G7cKnNmG92NeiBkXxdTYlinJQ52sai+WA1 /QtIQjyQ==; Message-ID: <11326ea0-51fb-445c-bae3-f16c40af87a3@luigi311.com> Date: Mon, 8 Apr 2024 23:23:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/25] media: i2c: imx258: Add get_selection for pixel array information To: Pavel Machek Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-12-git@luigi311.com> Content-Language: en-US From: Luis Garcia In-Reply-To: X-Authenticated-Id: git@luigi311.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_222830_423323_F00A70DD X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/3/24 12:46, Pavel Machek wrote: > Hi! > >> Libcamera requires the cropping information for each mode, so >> add this information to the driver. > >> @@ -116,6 +124,9 @@ struct imx258_mode { >> u32 link_freq_index; >> /* Default register values */ >> struct imx258_reg_list reg_list; >> + >> + /* Analog crop rectangle. */ > > No need for "." at the end, as it is not above. > >> + struct v4l2_rect crop; >> }; > > If the crop is same in all modes, should we have it in common place? > > Best regards, > Pavel I gave this a try similar to what was done on imx219 but its having issues and makes a bunch of changes to the following patches so we might need to hold off on that change for now. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel