From: Heiko Stuebner <heiko@sntech.de>
To: linus.walleij@linaro.org, jic23@kernel.org, lars@metafoo.de,
haibo.chen@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
ktsai@capellamicro.com, risca@dalakolonin.se,
christophe.jaillet@wanadoo.fr, dan.carpenter@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Ruan Jinjie <ruanjinjie@huawei.com>
Cc: ruanjinjie@huawei.com
Subject: Re: [PATCH -next] iio: adc: Remove redundant dev_err_probe()
Date: Fri, 28 Jul 2023 20:23:04 +0200 [thread overview]
Message-ID: <115418516.nniJfEyVGO@phil> (raw)
In-Reply-To: <20230727073912.4178659-1-ruanjinjie@huawei.com>
Am Donnerstag, 27. Juli 2023, 09:39:12 CEST schrieb Ruan Jinjie:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from either the platform_get_irq() or
> platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/iio/adc/rockchip_saradc.c | 2 +-
For Rockchip:
Acked-by: Heiko Stuebner <heiko@sntech.de>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 4b011f7eddec..8270652244c2 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -467,7 +467,7 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return dev_err_probe(&pdev->dev, irq, "failed to get irq\n");
> + return irq;
>
> ret = devm_request_irq(&pdev->dev, irq, rockchip_saradc_isr,
> 0, dev_name(&pdev->dev), info);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-28 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 7:39 [PATCH -next] iio: adc: Remove redundant dev_err_probe() Ruan Jinjie
2023-07-28 18:23 ` Heiko Stuebner [this message]
2023-07-28 20:00 ` Linus Walleij
2023-07-29 11:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115418516.nniJfEyVGO@phil \
--to=heiko@sntech.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@linaro.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=risca@dalakolonin.se \
--cc=ruanjinjie@huawei.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox