public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: commit 4dd1837d7589f468ed109556513f476e7a7f9121 breaks build
Date: Tue, 22 Nov 2016 12:11:41 +0100	[thread overview]
Message-ID: <11556597.ehuL0N36ia@wuerfel> (raw)
In-Reply-To: <20161120172248.GW1041@n2100.armlinux.org.uk>

On Sunday, November 20, 2016 5:22:48 PM CET Russell King - ARM Linux wrote:
> - not touching:
>         arch/arm/lib/csumpartialcopy.S
>         arch/arm/lib/csumpartialcopygeneric.S
>         arch/arm/lib/csumpartialcopyuser.S
> 
> other than that, it's doing the same thing.
> 
> I think Arnd's changes to the csumpartial code are unnecessary, and
> yours is, although larger, puts the asm/export.h include in the right
> place.  So please drop yours into the patch system so we can move
> forward fixing some of the problems created during the last merge
> window.

Right, the csumpartialcopy*.S changes are no longer needed after
commit cc6acc11cad1 ("kbuild: be more careful about matching
preprocessed asm ___EXPORT_SYMBOL") solves the problem more
generally.

I've submitted a new version of my patch, now just adding the
one header file that is needed to get MODVERSIONS back working,
plus the second patch for mmiocpy/mmioset to partially revert
Al's original change.

	Arnd

  reply	other threads:[~2016-11-22 11:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-20  2:47 commit 4dd1837d7589f468ed109556513f476e7a7f9121 breaks build Tobias Jakobi
2016-11-20 11:30 ` Russell King - ARM Linux
2016-11-20 11:43   ` Tobias Jakobi
2016-11-20 12:34     ` Russell King - ARM Linux
2016-11-20 12:56       ` Tobias Jakobi
2016-11-20 13:25         ` Russell King - ARM Linux
2016-11-20 17:03           ` Nicolas Pitre
2016-11-20 17:22             ` Russell King - ARM Linux
2016-11-22 11:11               ` Arnd Bergmann [this message]
2016-11-20 13:02       ` Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11556597.ehuL0N36ia@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox