From: "Nuno Sá" <noname.nuno@gmail.com>
To: Alexandru Ardelean <aardelean@baylibre.com>, nuno.sa@analog.com
Cc: chrome-platform@lists.linux.dev,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Cosmin Tanislav <cosmin.tanislav@analog.com>,
linux-arm-kernel@lists.infradead.org,
Guenter Roeck <groeck@chromium.org>,
Dmitry Rokosov <ddrokosov@sberdevices.ru>,
Benson Leung <bleung@chromium.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 08/20] iio: accel: cros_ec_accel_legacy: make use of iio_get_masklength()
Date: Wed, 03 Jul 2024 09:08:14 +0200 [thread overview]
Message-ID: <115b0657ff02ea10c9d0687a637759ed4164ffaa.camel@gmail.com> (raw)
In-Reply-To: <CA+GgBR-uazN8==3FHWo6Vb_Y3YEoMMnOLqJnfXtAsrS7Pc6B1g@mail.gmail.com>
On Wed, 2024-07-03 at 09:37 +0300, Alexandru Ardelean wrote:
> On Tue, Jul 2, 2024 at 7:02 PM Nuno Sa via B4 Relay
> <devnull+nuno.sa.analog.com@kernel.org> wrote:
> >
> > From: Nuno Sa <nuno.sa@analog.com>
> >
> > Ue iio_get_masklength() to access '.masklength' so it can be annotated
> > as __private when there are no more direct users of it.
> >
>
> I would have suggested maybe a "iio_for_each_active_channel()" here
> instead, but after looking into the driver a bit more, it looks like
> it's part of a broader rework.
>
Yeah, we have a scan_mask that I don't think it's guaranteed to be indio_dev-
>active_scan_mask. Also don't think (at this point) we need another
iio_for_each_active_channel() helper which takes mask as most of usecases use
indio_dev->active_scan_mask
- Nuno Sá
>
next prev parent reply other threads:[~2024-07-03 7:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 16:02 [PATCH 00/20] iio: make masklength __private (round 1) Nuno Sa via B4 Relay
2024-07-02 16:02 ` [PATCH 01/20] iio: core: add accessors 'masklength' Nuno Sa via B4 Relay
2024-07-03 6:10 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 02/20] iio: core: make use of iio_get_masklength() Nuno Sa via B4 Relay
2024-07-03 6:13 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 03/20] iio: buffer: " Nuno Sa via B4 Relay
2024-07-03 6:14 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 04/20] iio: accel: adxl367: " Nuno Sa via B4 Relay
2024-07-03 6:15 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 05/20] iio: accel: adx1372: " Nuno Sa via B4 Relay
2024-07-03 6:17 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 06/20] iio: accel: bma180: make use of iio_for_each_active_channel() Nuno Sa via B4 Relay
2024-07-03 6:23 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 07/20] iio: accel: bmc150-accel-core: " Nuno Sa via B4 Relay
2024-07-03 6:24 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 08/20] iio: accel: cros_ec_accel_legacy: make use of iio_get_masklength() Nuno Sa via B4 Relay
2024-07-03 6:37 ` Alexandru Ardelean
2024-07-03 7:08 ` Nuno Sá [this message]
2024-07-02 16:02 ` [PATCH 09/20] iio: accel: fxls8962af-core: make use of iio_for_each_active_channel() Nuno Sa via B4 Relay
2024-07-03 6:25 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 10/20] iio: accel: msa311: " Nuno Sa via B4 Relay
2024-07-03 6:26 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 11/20] iio: accel: sca3300: " Nuno Sa via B4 Relay
2024-07-03 6:26 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 12/20] iio: accel: stk8312: " Nuno Sa via B4 Relay
2024-07-03 6:26 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 13/20] iio: accel: stk8ba50: " Nuno Sa via B4 Relay
2024-07-03 6:26 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 14/20] iio: adc: ad7266: make use of iio_get_masklength() Nuno Sa via B4 Relay
2024-07-03 6:40 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 15/20] iio: adc: ad7298: " Nuno Sa via B4 Relay
2024-07-03 6:41 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 16/20] iio: adc: ad799x: " Nuno Sa via B4 Relay
2024-07-03 6:21 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 17/20] iio: adc: ad_sigma_delta: use new '.masklength' accessors Nuno Sa via B4 Relay
2024-07-03 6:41 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 18/20] iio: adc: at91_adc: make use of iio_for_each_active_channel() Nuno Sa via B4 Relay
2024-07-03 6:25 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 19/20] iio: imu: adis16475: " Nuno Sa via B4 Relay
2024-07-03 6:41 ` Alexandru Ardelean
2024-07-02 16:02 ` [PATCH 20/20] iio: imu: adis16480: " Nuno Sa via B4 Relay
2024-07-03 6:42 ` Alexandru Ardelean
2024-07-02 20:26 ` [PATCH 00/20] iio: make masklength __private (round 1) Jonathan Cameron
2024-07-03 7:10 ` Nuno Sá
2024-07-06 10:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115b0657ff02ea10c9d0687a637759ed4164ffaa.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=aardelean@baylibre.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@tuxon.dev \
--cc=cosmin.tanislav@analog.com \
--cc=ddrokosov@sberdevices.ru \
--cc=groeck@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).