From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06F15C2BD09 for ; Wed, 3 Jul 2024 07:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VaQH8FnAeZDc8Csmsnv9JLeK47HkCPT9RMwfnkOGtnM=; b=KWv5jl28VFX+zFXIT8fIOmsvyE g7wRj0bjipdo8KeUX0d5qfkqdaqF9TsMcmSulHDOKcWZCDQeoF0WFG9vVuU9kL1y4Oq4jDaY04AcW bqf+WdVkaLzmFM3/MFsLvhgqIn3+UeDYg/yw8G1QpBryqw9lONMK9kw2WZUj5ewjFSrsWntJjW8wG TUIdiqjAIUYlyF+VCGoN88om0x6KL2FvMJxfCmZC7gi7HXUM3Kd5ezDB1Fi68F1r+wvt2TVtOXK6h 5aj3AuEVasG/viiYtM7VTubVyxqiMd+Jr9oVPIcTkclVpf2HdmsG+mFsJ9cv3+hMtmZEmAAu9EDrx 2gNq4K4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOu2f-00000009HdI-0t6Y; Wed, 03 Jul 2024 07:04:37 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOu2T-00000009HcB-0NMa for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2024 07:04:26 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-36796aee597so22176f8f.1 for ; Wed, 03 Jul 2024 00:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719990263; x=1720595063; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=VaQH8FnAeZDc8Csmsnv9JLeK47HkCPT9RMwfnkOGtnM=; b=a/uN1o7VJUhN0xGpdUrgn3HjsgI1eCmH6xu0oDC5yIqYzSTtdkqX5JTMxZdmKAYGNV Bfawtv3wZr6rYXsgXGJiUWMBm5YDTVgiCIb0tkVcSrPiZ4lpw8Egbc5CIpBEvnZWxn/L ZC2qdHucziJAMydjK8IrVoYQCcmoi8OTRprIksWJtwW8uMtQ/Dre5NCja6dT4gmCNLtw losdgyXIG5ECVHx71Tg1K8z47wjjl9yUrYkeIKmzbMTlLknin8B3MtKtLWUD4D6RPe6e 9rglbIHhVJ7yRA2wxCpM27nwFC8gkna1hslXA6FL9ZkaVvlJCHHRptky4DGacUqni4yG 9EzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719990263; x=1720595063; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VaQH8FnAeZDc8Csmsnv9JLeK47HkCPT9RMwfnkOGtnM=; b=mB5WDR/VCc7Hdxqxdf7mjIgQHGWqdJzS+6wI1/QEICBGyq/oV024zwX5xoFSaojluD GLcnm/uVSH4e0sbxIFnfMFpg0py45pp8Do6L+6VcpLTIE6BB/iRW7TkXaEoJGTcwGNuQ H2//N0GGth5d+pkG42k7NguyDcx3Wq2HhzVEgjxqwuY7N/USDVF/7/0Gs5LthaRkpg+N qy1YUMnw6WdOd0th79nEkw++d5Df7fne6LfePO/9hHXQjC4Xf3OuP1E3VSOx0N726rfL 82LcxjdkbaSyTU/QR35TFd6XBZ0MOiKp+m9sgUR2jIfxE63EJYLIJQRLsZ8WtZrjg8If hRxQ== X-Forwarded-Encrypted: i=1; AJvYcCWvngNaAdJ+xUSqK/Mrw9rR/jYjbSfWxyvv3FMWWTGFjF0NzBk16xMasvJ3RdflPthC/8jqtjmt6B5HWNDOw21Lg+Uxm1jM8gRCN7deLuvjnXBW87I= X-Gm-Message-State: AOJu0Yyu/QuUp5gysMyQAdOtG4EJJGjt1jjE3FD/tbK2qBdaC3Tdsydz xftCcEnpz9gfB5b5ezFFusTYZj4fOxu2yIahRhJlgdovgMHo91jM X-Google-Smtp-Source: AGHT+IF1/X4CW1biRaLUYQHCJICLl9pL8jg7bhq/psGQ54W0jjdfLvD12ERfTNls96cW+bjZA37eHA== X-Received: by 2002:a5d:4576:0:b0:367:84ae:ddac with SMTP id ffacd0b85a97d-36784aedff1mr2314026f8f.17.1719990262321; Wed, 03 Jul 2024 00:04:22 -0700 (PDT) Received: from ?IPv6:2003:f6:ef1c:c500:ee59:d953:f148:40ba? (p200300f6ef1cc500ee59d953f14840ba.dip0.t-ipconnect.de. [2003:f6:ef1c:c500:ee59:d953:f148:40ba]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0cd6b4sm14991759f8f.17.2024.07.03.00.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 00:04:22 -0700 (PDT) Message-ID: <115b0657ff02ea10c9d0687a637759ed4164ffaa.camel@gmail.com> Subject: Re: [PATCH 08/20] iio: accel: cros_ec_accel_legacy: make use of iio_get_masklength() From: Nuno =?ISO-8859-1?Q?S=E1?= To: Alexandru Ardelean , nuno.sa@analog.com Date: Wed, 03 Jul 2024 09:08:14 +0200 In-Reply-To: References: <20240702-dev-iio-masklength-private-v1-0-98193bf536a6@analog.com> <20240702-dev-iio-masklength-private-v1-8-98193bf536a6@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_000425_150266_28E8E460 X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chrome-platform@lists.linux.dev, Alexandre Belloni , Lars-Peter Clausen , Michael Hennerich , linux-iio@vger.kernel.org, Claudiu Beznea , Cosmin Tanislav , linux-arm-kernel@lists.infradead.org, Guenter Roeck , Dmitry Rokosov , Benson Leung , Jonathan Cameron Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2024-07-03 at 09:37 +0300, Alexandru Ardelean wrote: > On Tue, Jul 2, 2024 at 7:02=E2=80=AFPM Nuno Sa via B4 Relay > wrote: > >=20 > > From: Nuno Sa > >=20 > > Ue iio_get_masklength() to access '.masklength' so it can be annotated > > as __private when there are no more direct users of it. > >=20 >=20 > I would have suggested maybe a "iio_for_each_active_channel()" here > instead, but after looking into the driver a bit more, it looks like > it's part of a broader rework. >=20 Yeah, we have a scan_mask that I don't think it's guaranteed to be indio_de= v- >active_scan_mask. Also don't think (at this point) we need another iio_for_each_active_channel() helper which takes mask as most of usecases u= se indio_dev->active_scan_mask - Nuno S=C3=A1 >=20