From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 604A4C32771 for ; Sat, 4 Jan 2020 21:23:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 158E324650 for ; Sat, 4 Jan 2020 21:23:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fnp6K0CS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 158E324650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fQHQ4+mkDyhNe9O+EEkwZHB2ss9WaNmFUMGd5SJERss=; b=fnp6K0CS1hz5z6 yqHTovmiXYUy++1d5CxbL7WI2iJMHj3fk4FE+7oCLfWEioLFYxiEyyHlwZR0b4nW9fZUVPTGzn4Kr sCeuy1Scbbn4J0WjG5lwBkr8hsTH6IWwcXYDUNyihy2R3uJvbbWIJE4bgILSDP0Bn3B0DTsvV7KEK py1GOdFZwJvWyBkjt4y91pz86bSd6Q+3NrK/o8dCseVP1hO4b+n+Q2uaroyjqteHjQrJjvq3VSJI8 1Fa+JMcEAYsLICWlDmaH/tH3aGU45vt9rnBvfwUtc9qR7zwL8816ovxQ6AeNKlDZhBv4i2bTKJkbr x2srD45R2LNUPYz/akVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inqt7-0002NY-UG; Sat, 04 Jan 2020 21:23:13 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inqt4-0002MN-Ex; Sat, 04 Jan 2020 21:23:11 +0000 Received: from p508fd2bb.dip0.t-ipconnect.de ([80.143.210.187] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inqsy-00048F-1e; Sat, 04 Jan 2020 22:23:04 +0100 From: Heiko Stuebner To: Markus Reichl Subject: Re: [PATCH 5/5] arm64: dts: rockchip: Enable mp8859 regulator on rk3399-roc-pc Date: Sat, 04 Jan 2020 22:23:03 +0100 Message-ID: <11639547.aalzkRAYeW@phil> In-Reply-To: <20200104153321.6584-6-m.reichl@fivetechno.de> References: <20200104153321.6584-1-m.reichl@fivetechno.de> <20200104153321.6584-6-m.reichl@fivetechno.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200104_132310_650638_8A300FBD X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Markus, Am Samstag, 4. Januar 2020, 16:32:49 CET schrieb Markus Reichl: > The rk3399-roc-pc uses a MP8859 DC/DC converter for 12V supply. > This supplies 5V only in default state after booting. Just for my understanding ... both the old static regulator before as well as the new i2c node said to supply 12V, but above you say that the default is 5V ... so I'm wondering who configured the 12V before. Or was it the case that the old regulator node was just wrong and we had 5V running on the dc_12v line? Thanks Heiko > Now we can control the output voltage via I2C interface. > Add a node for the driver to reach 12V. > > Signed-off-by: Markus Reichl > --- > .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 32 +++++++++++-------- > 1 file changed, 18 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > index 8e01b04144b7..9f225e9c3d54 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > @@ -110,20 +110,6 @@ vcc_vbus_typec0: vcc-vbus-typec0 { > regulator-max-microvolt = <5000000>; > }; > > - /* > - * should be placed inside mp8859, but not until mp8859 has > - * its own dt-binding. > - */ > - dc_12v: mp8859-dcdc1 { > - compatible = "regulator-fixed"; > - regulator-name = "dc_12v"; > - regulator-always-on; > - regulator-boot-on; > - regulator-min-microvolt = <12000000>; > - regulator-max-microvolt = <12000000>; > - vin-supply = <&vcc_vbus_typec0>; > - }; > - > /* switched by pmic_sleep */ > vcc1v8_s3: vcca1v8_s3: vcc1v8-s3 { > compatible = "regulator-fixed"; > @@ -546,6 +532,24 @@ fusb0: usb-typec@22 { > vbus-supply = <&vcc_vbus_typec0>; > status = "okay"; > }; > + > + mp8859: regulator@66 { > + compatible = "mps,mp8859"; > + reg = <0x66>; > + dc_12v: mp8859_dcdc { > + regulator-name = "dc_12v"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + regulator-always-on; > + regulator-boot-on; > + vin-supply = <&vcc_vbus_typec0>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <12000000>; > + }; > + }; > + }; > }; > > &i2s0 { > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel