linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] soc/rockchip: Restrict to ARCH_ROCKCHIP
@ 2015-10-09 13:46 Thierry Reding
  2015-10-11 10:02 ` Heiko Stübner
  0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2015-10-09 13:46 UTC (permalink / raw)
  To: linux-arm-kernel

From: Thierry Reding <treding@nvidia.com>

By definition this directory contains drivers that are specific to the
Rockchip architecture. All Kconfig options should therefore depend on
ARCH_ROCKCHIP to avoid exposing these symbols on other architectures.
For example, this options currently shows up as new when doing an
incremental build on PowerPC.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/soc/rockchip/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig
index 6ee03994801c..d09b5ede7deb 100644
--- a/drivers/soc/rockchip/Kconfig
+++ b/drivers/soc/rockchip/Kconfig
@@ -1,3 +1,5 @@
+if ARCH_ROCKCHIP
+
 #
 # Rockchip Soc drivers
 #
@@ -12,3 +14,5 @@ config ROCKCHIP_PM_DOMAINS
           mode. The RK3288 PMU is dedicated for managing the power of the whole chip.
 
           If unsure, say N.
+
+endif
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] soc/rockchip: Restrict to ARCH_ROCKCHIP
  2015-10-09 13:46 [PATCH] soc/rockchip: Restrict to ARCH_ROCKCHIP Thierry Reding
@ 2015-10-11 10:02 ` Heiko Stübner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2015-10-11 10:02 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Thierry,

Am Freitag, 9. Oktober 2015, 15:46:18 schrieb Thierry Reding:
> From: Thierry Reding <treding@nvidia.com>
> 
> By definition this directory contains drivers that are specific to the
> Rockchip architecture. All Kconfig options should therefore depend on
> ARCH_ROCKCHIP to avoid exposing these symbols on other architectures.
> For example, this options currently shows up as new when doing an
> incremental build on PowerPC.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

thanks for catching this and I agree that Rockchip stuff should not leak into 
other arches :-) .

I've applied this after adding a "|| COMPILE_TEST" alternative to the 
condition.


Thanks
Heiko

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-11 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-09 13:46 [PATCH] soc/rockchip: Restrict to ARCH_ROCKCHIP Thierry Reding
2015-10-11 10:02 ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).