public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [Y2038] [PATCH] drm/exynos: g2d: Replace struct timeval usage
Date: Mon, 01 Jun 2015 21:27:42 +0200	[thread overview]
Message-ID: <11771769.CzI59d4H3P@wuerfel> (raw)
In-Reply-To: <20150601030618.GA2754@tinar>

On Monday 01 June 2015 08:36:18 Tina Ruchandani wrote:
> -       do_gettimeofday(&now);
> +       getnstimeofday64(&now);
>         e->event.tv_sec = now.tv_sec;
> -       e->event.tv_usec = now.tv_usec;
> +       e->event.tv_usec = (now.tv_nsec / NSEC_PER_USEC);
>         e->event.cmdlist_no = cmdlist_no;
> 

This has the same problem as the ipp patch: e->event.tv_sec is
a 32-bit variable, so this will still overflow, and the patch
has no effect.

	Arnd

      reply	other threads:[~2015-06-01 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01  3:06 [PATCH] drm/exynos: g2d: Replace struct timeval usage Tina Ruchandani
2015-06-01 19:27 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11771769.CzI59d4H3P@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox