From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver
Date: Fri, 22 Jul 2016 15:27:04 +0200 [thread overview]
Message-ID: <11848764.OZ77lJYCM4@wuerfel> (raw)
In-Reply-To: <20160722105648.GD17584@leverpostej>
On Friday, July 22, 2016 11:56:49 AM CEST Mark Rutland wrote:
> Hi,
>
> I understand that some SoC/socket level PMU is accessed via these
> registers. It doesn't make sense to review either in isolation. Please
> put together a unified series, with both the djtag accessors and the
> PMU code.
>
> On it's own, it's *very* difficult to understand how this fits into the
> SoC, and how it is to be used.
Is there anything else that the driver is used for?
Having it in drivers/soc/ feels wrong to me, and if there is only
one user, I'd recommend having it as part of the same driver module
as the code accessing it.
Arnd
next prev parent reply other threads:[~2016-07-22 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 8:48 [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Tan Xiaojun
2016-07-22 8:48 ` [RFC PATCH v1 1/2] Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts bindings Tan Xiaojun
2016-07-22 8:48 ` [RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver Tan Xiaojun
2016-07-22 20:37 ` Paul Gortmaker
2016-07-25 1:54 ` Tan Xiaojun
2016-07-27 20:40 ` Paul Gortmaker
2016-07-22 10:56 ` [RFC PATCH v1 0/2] Add " Mark Rutland
2016-07-22 13:27 ` Arnd Bergmann [this message]
2016-07-25 2:09 ` Tan Xiaojun
2016-07-25 2:00 ` Tan Xiaojun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11848764.OZ77lJYCM4@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox