From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E948C32771 for ; Tue, 7 Jan 2020 02:43:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5B3D206E6 for ; Tue, 7 Jan 2020 02:43:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="od4OWsHa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5B3D206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LuuJc2w8FxDEH+N44csNPkU1tTFNGgLC4kxj7sJh7Kw=; b=od4OWsHaEnoqWv jbct+fmOBH0Ogvr6TCDWl0HBcqt81WEAwrH4eyLMKjGKUGS3JxBhvt9wrRhp9XDtig3rn9rAQ0nCK vJ96ABaKuSP3yHNtuNsEQBQKgcNMwrQNRehvOq7vXGUyMxaKcx4g9jqWTQ69gJlVy7uiLSGzrG7jB 1rpmmvUh7AR6yotZg7z0z1WAIb8Wxusgvvn/JHf0MsnL3cTsFs7os9uPWmAD5BizURGIYEbE1UfYb VxP1CWbbUdDIglcnczBalWdVQylB9qBf4+AUnV1/7UWwNYefKUpLN6iQomxqH8a/fTjDZj8+KJYEH 4zzE44IqTg5/kvqZ5aQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioeqL-0006Cy-RJ; Tue, 07 Jan 2020 02:43:41 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioeqH-0006BI-0D; Tue, 07 Jan 2020 02:43:38 +0000 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Tue, 7 Jan 2020 10:43:58 +0800 Subject: Re: [PATCH v3 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings To: Rob Herring References: <1577428606-69855-1-git-send-email-hanjie.lin@amlogic.com> <1577428606-69855-3-git-send-email-hanjie.lin@amlogic.com> <20200104003210.GA29074@bogus> From: Hanjie Lin Message-ID: <11875bd0-0248-4c68-964a-004e1d15ab83@amlogic.com> Date: Tue, 7 Jan 2020 10:43:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200104003210.GA29074@bogus> Content-Language: en-US X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200106_184337_050781_F0837062 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Martin Blumenstingl , Jian Hu , Liang Yang , Qiufang Dai , Xingyu Chen , Kevin Hilman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/1/4 8:32, Rob Herring wrote: > On Fri, Dec 27, 2019 at 02:36:42PM +0800, Hanjie Lin wrote: >> The Amlogic A1 SoC Family embeds 1 USB Controllers: >> - a DWC3 IP configured as Host for USB2 and USB3 >> >> A glue connects the controllers to the USB2 PHY of A1 SoC. >> >> Signed-off-by: Hanjie Lin >> Signed-off-by: Yue Wang >> --- >> .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 57 +++++++++++++++++++--- >> 1 file changed, 51 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >> index 4efb77b..6103cc2 100644 >> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >> @@ -9,6 +9,8 @@ title: Amlogic Meson G12A DWC3 USB SoC Controller Glue >> >> maintainers: >> - Neil Armstrong >> + - Hanjie Lin >> + - Yue Wang >> >> description: | >> The Amlogic G12A embeds a DWC3 USB IP Core configured for USB2 and USB3 >> @@ -22,10 +24,14 @@ description: | >> The DWC3 Glue controls the PHY routing and power, an interrupt line is >> connected to the Glue to serve as OTG ID change detection. >> >> + The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in >> + host-only mode. >> + >> properties: >> compatible: >> enum: >> - amlogic,meson-g12a-usb-ctrl >> + - amlogic,meson-a1-usb-ctrl >> >> ranges: true >> >> @@ -37,6 +43,11 @@ properties: >> >> clocks: >> minItems: 1 >> + maxItems: 4 >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 4 >> >> resets: >> minItems: 1 >> @@ -47,17 +58,22 @@ properties: >> interrupts: >> maxItems: 1 >> >> + phys: >> + minItems: 1 >> + maxItems: 3 >> + >> phy-names: >> items: >> - const: usb2-phy0 # USB2 PHY0 if USBHOST_A port is used >> - const: usb2-phy1 # USB2 PHY1 if USBOTG_B port is used >> - const: usb3-phy0 # USB3 PHY if USB3_0 is used >> >> - phys: >> - minItems: 1 >> - maxItems: 3 >> - > > Why the unnecessary move? > I saw most "phys" attributes are front of "phy-names" in dts, maybe looks pretty no other reasons. >> - dr_mode: true >> + dr_mode: >> + description: usb mode for G12A >> + enum: >> + - host >> + - peripheral >> + - otg > > No, this is a common property that doesn't need to be redefined here. It > was correct as-is. > Ok, I will modify it. >> >> power-domains: >> maxItems: 1 >> @@ -80,9 +96,9 @@ required: >> - resets >> - reg >> - interrupts >> - - phy-names >> - phys >> - dr_mode >> + - phy-names > > Again, unnecessary change. > Ok >> >> examples: >> - | >> @@ -124,4 +140,33 @@ examples: >> snps,quirk-frame-length-adjustment; >> }; >> }; >> + - | >> + a1_usb: usb@ffe09000 { > > You are only adding a compatible. No need for a whole new example. > Ok, I will fix it. Thanks, Hanjie >> + status = "okay"; >> + compatible = "amlogic,meson-a1-usb-ctrl"; >> + reg = <0 0xffe09000 0x0 0xa0>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> >> + clocks = <&clkc_periphs 36>, >> + <&clkc_periphs 85>, >> + <&clkc_periphs 2>, >> + <&clkc_periphs 3>; >> + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_phy", >> + "xtal_usb_ctrl"; >> + >> + resets = <&reset 36>; >> + >> + phys = <&usb2_phy1>; >> + phy-names = "usb2-phy1"; >> + >> + a1_dwc3: usb@ff400000 { >> + compatible = "snps,dwc3"; >> + reg = <0xff400000 0x100000>; >> + interrupts = <0 90 4>; >> + dr_mode = "host"; >> + snps,dis_u2_susphy_quirk; >> + snps,quirk-frame-length-adjustment = <0x20>; >> + }; >> + }; >> -- >> 2.7.4 >> > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel