public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions from common.h
Date: Tue, 30 Sep 2014 12:38:58 +0200	[thread overview]
Message-ID: <11948982.c37J1JPj8N@wuerfel> (raw)
In-Reply-To: <1412072481-22370-3-git-send-email-pankaj.dubey@samsung.com>

On Tuesday 30 September 2014 15:51:21 Pankaj Dubey wrote:
> 
> +static inline void pmu_raw_writel(u32 val, u32 offset)
> +{
> +       __raw_writel(val, pmu_base_addr + offset);
> +}
> +
> +static inline u32 pmu_raw_readl(u32 offset)
> +{
> +       return __raw_readl(pmu_base_addr + offset);
> +}
> +
> 

While you're at it, please convert these to use readl_relaxed() instead,
which is safe to use in drivers and works independent of CPU endianess.

	Arnd

  reply	other threads:[~2014-09-30 10:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 10:21 [PATCH v8 0/2] ARM: Exynos: Convert PMU implementation into a platform driver Pankaj Dubey
2014-09-30 10:21 ` [PATCH v8 1/2] ARM: EXYNOS: Add platform driver support for Exynos PMU Pankaj Dubey
2014-09-30 10:21 ` [PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions from common.h Pankaj Dubey
2014-09-30 10:38   ` Arnd Bergmann [this message]
2014-10-01  2:59     ` Pankaj Dubey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11948982.c37J1JPj8N@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox