From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4020C433DF for ; Tue, 21 Jul 2020 21:34:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DAD220717 for ; Tue, 21 Jul 2020 21:34:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A93VJbEq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DAD220717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z0GRU4mSvlcsG+pyeK+A1cJskbPqr+rRbPNFCZLxZgE=; b=A93VJbEqhUX7lj3FF8TJ5w20Z 8v2wOhUdd/8UPhRxiiEJiKOyrIXb2/AFjhBEZzHDeLBAMriHLzXDLZUJeIAg4MxB2mqkkwxjzH9qM ZsStBJNYSHoXGOoq+7uSZVBGSuDlikycTW6ZHMhTpcdnA3/mHZ+gRd5SgLOnWslHaVC9cnBbYLzP4 vo++uvdxHZvUTaTWrW4YhtnJRJPJ6unDGF/Xd7QnYxWd60mW/LS+G8TE1kGoS6WuA6WQLAxwLWzef tBNOrCf4xb9owneZ42yp2KMA0f7mon2gcXH7RjRJVsaNg02L6yqOAdCwUIgcizaDzAScLQd5i9r9S X/IsZap6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxzs6-0005Uq-Pn; Tue, 21 Jul 2020 21:32:22 +0000 Received: from smtprelay0062.hostedemail.com ([216.40.44.62] helo=smtprelay.hostedemail.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxzs4-0005UJ-KN for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 21:32:21 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 469E718224D68; Tue, 21 Jul 2020 21:32:18 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: loaf72_4608e2426f30 X-Filterd-Recvd-Size: 2717 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA; Tue, 21 Jul 2020 21:32:16 +0000 (UTC) Message-ID: <11ac49bc33546ef9ebc4120878206bd882667d8a.camel@perches.com> Subject: Re: [PATCH v4 16/17] crypto: sun8i-ce: fix comparison of integer expressions of different signedness From: Joe Perches To: Corentin Labbe , davem@davemloft.net, herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org Date: Tue, 21 Jul 2020 14:32:15 -0700 In-Reply-To: <1595358391-34525-17-git-send-email-clabbe@baylibre.com> References: <1595358391-34525-1-git-send-email-clabbe@baylibre.com> <1595358391-34525-17-git-send-email-clabbe@baylibre.com> User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_173220_721726_9D2A1AE8 X-CRM114-Status: GOOD ( 15.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-07-21 at 19:06 +0000, Corentin Labbe wrote: > This patch fixes the warning: > warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare] I think these do not really need conversion. Are these useful compiler warnings ? > Signed-off-by: Corentin Labbe > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > index 3901e3401c6b..7b2a142c9b8d 100644 > --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > @@ -566,7 +566,7 @@ static struct sun8i_ce_alg_template ce_algs[] = { > static int sun8i_ce_dbgfs_read(struct seq_file *seq, void *v) > { > struct sun8i_ce_dev *ce = seq->private; > - int i; > + unsigned int i; > > for (i = 0; i < MAXFLOW; i++) > seq_printf(seq, "Channel %d: nreq %lu\n", i, ce->chanlist[i].stat_req); > @@ -778,7 +778,8 @@ static int sun8i_ce_get_clks(struct sun8i_ce_dev *ce) > > static int sun8i_ce_register_algs(struct sun8i_ce_dev *ce) > { > - int ce_method, err, id, i; > + int ce_method, err, id; > + unsigned int i; > > for (i = 0; i < ARRAY_SIZE(ce_algs); i++) { > ce_algs[i].ce = ce; > @@ -858,7 +859,7 @@ static int sun8i_ce_register_algs(struct sun8i_ce_dev *ce) > > static void sun8i_ce_unregister_algs(struct sun8i_ce_dev *ce) > { > - int i; > + unsigned int i; > > for (i = 0; i < ARRAY_SIZE(ce_algs); i++) { > if (!ce_algs[i].ce) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel