From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCF5AC2BD09 for ; Tue, 9 Jul 2024 16:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+mmzHYcsrbq/WzadmZBrEv0IGke8Kg4qTQXnrPrl/hk=; b=l/Imuo8NZHu4j/8fWofXnRpywD uy2eq75GgLphL4urxDsW04WeJHhgQNRCoq4XJeDeocROtVuc0xMzZWfoOscFwkkjzPcMkcNSU7gjI Ews2kZLJamArw6yAgZrAm7IAC+vQHc22I6e2m0C/wKVQAes4mJBO16gSz2BhwrJ5uS6gBBtRaJGUf j1/ISTzJRnMbgsY0OuvHsdWyOFBsLCPhGFzgTZRxMExepR7DksVd8KU1Nv+uQeRIbbRe56TFLcLlN gOuFAf67R3UAKwMnk0OeABIBPxY+L9RwgCCnxjjf16VMDVvXsCUTunGmWClZMgFWTpfHV7OFJprkN Dt0ig5aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRDVa-00000007tQJ-0NiR; Tue, 09 Jul 2024 16:16:02 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRDVI-00000007tJr-029y for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 16:15:45 +0000 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2eeb1051360so19084781fa.0 for ; Tue, 09 Jul 2024 09:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720541742; x=1721146542; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+mmzHYcsrbq/WzadmZBrEv0IGke8Kg4qTQXnrPrl/hk=; b=GjTnFsL5biXUY2eIwMIPyAksdMkU09Q5tvixI/C0bH46GTf0VWY2tGnQNkw5+Uxfo2 v6GfE1w7bV2G731U0RKmRh78yaOqumRPu/NYuILVVwAIcBf6KuBusy3hgpv+aHoNClyU 8WOk/SZheMhlmqxmDPolWmVWGSegZAVQqq/6eELLuOJJIc81Ldeh7UiIFlf5kLPKhled yZSxDpk67ai8osU8zPxkpOlFFXPJPrIW/yedLSumNfkxOmZ/fw0Y4hYaRtlgFnKfcpP6 MHBQIdq1VElquXxMxApPPPZn0lsbIIaYRRUcZADJdgMy05TP1vjmpBKPo2OcYHOTuVUJ Pyeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720541742; x=1721146542; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+mmzHYcsrbq/WzadmZBrEv0IGke8Kg4qTQXnrPrl/hk=; b=tFuRETnLb7Nax1aFrBe+6JrO9kyionISEZkzBntnUKMTaUWXPY+1eWD+lL6SsZB/1E iPxCViyLIjMuBnqdwyKG0Bn+kfjn3le1I0oPQAKMqUHhsUmrkFX5ACkdar1OTDCWIJT9 0RoP4jku+ZXOkyLV37gBwSUkivzJyxfJh0qqJoeimZ/m3NlV2lTIROS6m4epuBixLVYV IJ1QPpFXljmI5otFDn1ghiDx4gsYaN1Mw4rGEv5c8HbjJYgmXa6tddZwP51nMR0cJ5rI XpiZU4DGuVoLgkuKWMbC1MaiuM7xjavRYIpWLvfL0/EgWZmWWZF7XDKm9Ea0WVIJoa1y YJcA== X-Forwarded-Encrypted: i=1; AJvYcCWblvXsLd9YHrWw6WomvOwzfgjs/Hd7doUkhFhYZlBTZLe63NihLLxx23A8Rim8hNVxzLgDrnGw46POmcXbvOP0b4aN2dyesSyCl4OM83zPo6qaqpA= X-Gm-Message-State: AOJu0Yx02LFieKdof3SSK5tJ/r4fkqk369+j8cXvGW/WYA5o0rqm5lAg /6F0uCX49A6AXKt6qvBam6AjB/x9u28AEd0cMQ2vSzEEe+bG/WtFSVyG0wPDYV88gR1dvm4GpvB e X-Google-Smtp-Source: AGHT+IEzXFlniImG/MtXKk3DCbQfzXjVjTAPnBQm4R1NlkNg4Akwf+zffKFhwFSImt1CnEXQreVDBQ== X-Received: by 2002:a2e:a415:0:b0:2ee:8ce9:3075 with SMTP id 38308e7fff4ca-2eeb3197a5fmr18174151fa.49.1720541742014; Tue, 09 Jul 2024 09:15:42 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:6932:abde:fac8:217d? ([2a05:6e02:1041:c10:6932:abde:fac8:217d]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-367cde891cesm2972937f8f.62.2024.07.09.09.15.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jul 2024 09:15:41 -0700 (PDT) Message-ID: <11c5de84-21f0-45de-81e0-dc765a391123@linaro.org> Date: Tue, 9 Jul 2024 18:15:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] clocksource: sp804: Make user selectable To: Mark Brown Cc: Thomas Gleixner , David Abdurachmanov , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ross Burton References: <20240529-arm64-vexpress-sp804-v2-1-c542a80af33a@kernel.org> <2b946a68-dcdd-4a1e-b7c3-416725033c2e@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_091544_075952_5812EDB4 X-CRM114-Status: GOOD ( 18.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/07/2024 19:44, Mark Brown wrote: > On Mon, Jul 08, 2024 at 06:49:38PM +0200, Daniel Lezcano wrote: >> On 29/05/2024 21:48, Mark Brown wrote: > >>> The sp804 is currently only user selectable if COMPILE_TEST, this was >>> done by commit dfc82faad725 ("clocksource/drivers/sp804: Add >>> COMPILE_TEST to CONFIG_ARM_TIMER_SP804") in order to avoid it being >>> spuriously offered on platforms that won't have the hardware since it's >>> generally only seen on Arm based platforms. This config is overly >>> restrictive, while platforms that rely on the SP804 do select it in >>> their Kconfig there are others such as the Arm fast models which have a >>> SP804 available but currently unused by Linux. Relax the dependency to >>> allow it to be user selectable on arm and arm64 to avoid surprises and >>> in case someone comes up with a use for extra timer hardware. > >> Would it make sense to add the option in the platform so it selects the >> timer ? > > As the commit log says far as I'm aware all the platforms that rely on > the sp804 timer already select it (they wouldn't otherwise be able to > work unless COMPILE_TEST was enabled). The Arm models and possibly > other platforms have the sp804 but it will currently be ignored by Linux > and the architected timers used instead so it would be wasteful to force > it on for them. The policy of the Kconfig is we should keep the option silent. My suggestion was to provide the option in the platforms Kconfig and [un]select the ARM_TIMER_SP804 from there -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog