From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADF67C433EF for ; Mon, 27 Jun 2022 06:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jfYyOMzKXSIFHXRDFiRamKMuAkYHkyXhq7ilVR8F4CE=; b=baZL+YzudHfje4 Xt/DTFAL1qizK5aQpa/lz3X1YNMdxLClnO5gTQ+t6YMN/uhOt+9Ya4gV636rDSldBvoNWxn49JgEp mZFp1J6AIvXAIdJyagt3GBF3E63xlRxqev2uolCoqPwzFCwxxkGO20qaJnuscJRkoNOhI4RF1VyvZ IMVIhnhXaUSLU3VzanRI7i6ledgwFccGvfqd8HP84ZhonrzXKVjGaMPwf2v6CvfItIK47tuyQL1U5 JwjYEoj42W0ChsoRvGpN3ZCpa2vYKZ0GOUeiNT831kYyifqUeRjZUBiPsc7S1ulK30tqh7H1rrfnC FPtQ0OHnoHQeoz5R5vaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5hvd-00Fyyc-9o; Mon, 27 Jun 2022 06:08:58 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5hvU-00Fytj-Ou for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 06:08:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1656310128; x=1687846128; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=htDOVovcpqRBaikXfJ7j2k5qetneEiI479m7Kwr1SUo=; b=QfbgBHde66MX5KzqV0Ca4WBKHFgAs4yyfwZCSUUiNDfKNv6MDLgFEP65 k9pbJPAivUaQnWjzOcY6oiX9TqvzqROjt++mm5eL4f9nfrkZ+M+KK2K86 Y+G2JEgJkJ+WjMaOITLXq1RizTI+7hsHVXrhkh/4ueD36zBKvVaK0FUfW Tf68PsJeXs3Vr+C0tQBwXMpNxFISUENzaOgi/sbbs52NLOGFLgwOr09Ya eLNBd4pikqBL5GnnhGODukfUYWlwecmX3knBnNJcOLzFPhBPwEoAAtnkb QE3wfEYXqK3eHHlAqnXpCnQm2xWplqT3SRMHVUb7Y634OuZqDe/tjDOha g==; X-IronPort-AV: E=Sophos;i="5.92,225,1650924000"; d="scan'208";a="24676352" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 27 Jun 2022 08:08:42 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 27 Jun 2022 08:08:42 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 27 Jun 2022 08:08:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1656310122; x=1687846122; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=htDOVovcpqRBaikXfJ7j2k5qetneEiI479m7Kwr1SUo=; b=ZEi1VOjxAE1WAnsQmLCIfhLLs2czyOV0yGHu25nRQZE6WZvYOTRd5nDA FMKP5LnR7bPiLqnqj7QoFLIZqu8b+ALm+kmrKI7/kOPLUKCynhe4DbwOB 6P2ebJzoqrHcTPBy9h7+j5AUdasJQ7ftecuBjNitvzaIC4Wn9eW+jfRc+ Hdy6OMgsdMHm2GrhTsyGuxY5cma+m75QaSZsKVevq/k/peCcJlHAZ7N8q SJs/gI1pd7eHkKg2QIehFtqC5EpFWFQk8e3tAvSa2O3hCAhecYuOxnyIk P1Aupc4A1pZ5cVENjTtnJ2XldbYDg9LZUmp7LSJxGmEz7p/OEZtFS5/xh A==; X-IronPort-AV: E=Sophos;i="5.92,225,1650924000"; d="scan'208";a="24676351" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 27 Jun 2022 08:08:42 +0200 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 3FA69280071; Mon, 27 Jun 2022 08:08:42 +0200 (CEST) From: Alexander Stein To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Marek Vasut , Lucas Stach , Martyn Welch , Paul Elder , Shawn Guo Subject: Re: (EXT) [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful Date: Mon, 27 Jun 2022 08:08:39 +0200 Message-ID: <12006796.O9o76ZdvQC@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20220624182939.162298-1-marex@denx.de> References: <20220624182939.162298-1-marex@denx.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_230849_308199_38971AB6 X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 24. Juni 2022, 20:29:39 CEST schrieb Marek Vasut: > Print the name of the power domain which failed to make the error > prints actually useful for finding the error. > > Signed-off-by: Marek Vasut > Cc: Alexander Stein > Cc: Lucas Stach > Cc: Martyn Welch > Cc: Paul Elder > Cc: Shawn Guo > --- > drivers/soc/imx/imx8m-blk-ctrl.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) I did something similar locally. Especially the 1st two hunks are pretty useful. Acked-by: Alexander Stein > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c > b/drivers/soc/imx/imx8m-blk-ctrl.c index 7ebc28709e945..dff7529268e4d > 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -216,7 +216,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device > *pdev) bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus"); > if (IS_ERR(bc->bus_power_dev)) > return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev), > - "failed to attach power domain\n"); > + "failed to attach power domain \"bus\"\n"); > > for (i = 0; i < bc_data->num_domains; i++) { > const struct imx8m_blk_ctrl_domain_data *data = &bc_data->domains[i]; > @@ -238,7 +238,8 @@ static int imx8m_blk_ctrl_probe(struct platform_device > *pdev) dev_pm_domain_attach_by_name(dev, data->gpc_name); > if (IS_ERR(domain->power_dev)) { > dev_err_probe(dev, PTR_ERR(domain- >power_dev), > - "failed to attach power domain\n"); > + "failed to attach power domain \"%s\"\n", > + data->gpc_name); > ret = PTR_ERR(domain->power_dev); > goto cleanup_pds; > } > @@ -251,7 +252,9 @@ static int imx8m_blk_ctrl_probe(struct platform_device > *pdev) > > ret = pm_genpd_init(&domain->genpd, NULL, true); > if (ret) { > - dev_err_probe(dev, ret, "failed to init power domain\n"); > + dev_err_probe(dev, ret, > + "failed to init power domain \"%s\"\n", > + data->gpc_name); > dev_pm_domain_detach(domain->power_dev, true); > goto cleanup_pds; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel