From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53545C38145 for ; Tue, 6 Sep 2022 19:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jbs1oS7lK9/2PRUDzZ5NPRlHZY3yLlgZev6FvauUYI8=; b=nVm1FAP1r6cDjT kyA5gqNhQpm0mScVujusKGFtN6If8SyLPGmyGkzmQ9EB5xnz2sG2JE1Rlrv13LE/cOimeHDVK3iCw /G2cSIWbVivQEpHMP+7bdh4blHh+ZkD/ekIexrv3CaCPyFm5LAdxyWy91gk0FUWq43pnm7mCVT/y+ LQRZMUZvDWEtDtRpzpvuc8WIYS+/YzCcYILxPnE4eQAO7RdhD+EDtOzCQR1MxR38aOPb9Mw1HD25Y Av3/UfQsYH9vkJG/09cjf8lZy0uO6cxHarB89Jk2KaKr8Qy+o2DeaosonfmOw+KyYj6FW5Ex9gr4X 3HAQIzXWJKZLk4lxI3pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVdyD-00GaTK-19; Tue, 06 Sep 2022 19:10:49 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVdy9-00GaPX-AF for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 19:10:46 +0000 Received: by mail-ej1-x630.google.com with SMTP id fg1so3345714ejc.2 for ; Tue, 06 Sep 2022 12:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=w/ZOd8w9PpfH0PoP4VeEmJ6xZfMkRuDkUmQ7u7OOSbI=; b=oYm3QwusiprapdZgx34JgD15YXVl+0e25+F+6mUrTli6IPDa+bMXDhGUoyw6Iwo/Kv Vdlic0olw6Sky94t7Kx/GETDzah7M+tvgPlH6ZqJd1oL3TTOyNY/DXzfD5CErsy0tqLk W592WP0k+fS6kPfYk3EoaE3EXMod5fA0VyJmmPvfcCr6OKTLYsPj7YmMfeuHxlNVYmo+ 4Cy052KhsUtLHk3deXW+LKk2jyfERjdC4GUrNJXhu5jROJ1daMrdDubsIT2a8DGF6cFx lPsftlm1GUt761wyza6CRZ2snjPgJvoRml2/X3HdQixGvWLqjK9HTRVzW6vDHoBD6H3E i5/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=w/ZOd8w9PpfH0PoP4VeEmJ6xZfMkRuDkUmQ7u7OOSbI=; b=qfabgN/eItcE2rknChkC4hez9BW0kDNIJ1pKuIB6GwB83hDgTNHKKgnMYrf+5L+nRH pO++kxl2n5vaxtex8jSkRzTaQVlgemJivYNfa2yks+jtAX3ifZ4io7t96d4mcfIXErKx 5D7jxI+cWoUA4f9fuxvpGezozT+gvz3MhiUXH3hRcP4V9bKLipKyDSq3crMcKPgaeCt+ qnpxkQ8gqdOEWchcavsgqYTFEqrOnTklU6orkF/ljtENXEj5hPTYkr5h57F38HHyqrO1 fq62yiEoBQLHlPEt0z0hKvdP6ci+DffkIYmEz3Q54j3AwK0GiGr+7Rs5CLpfiyG0LmNi wt4w== X-Gm-Message-State: ACgBeo0oSxUaWv01FY/oZvOIo7mSv+iqW+AYMJgng4Cx/CEOFpufq7rR NpC9J/IY/jvhMYXRDziFEgg= X-Google-Smtp-Source: AA6agR5o/hB8ODtHH/gpw6zFvP+JmOgSI2ED73R2uoqAFYkPfIPG8L9e/o3qsvEJU6l4v+KqU6WtBg== X-Received: by 2002:a17:907:2c75:b0:741:5871:4318 with SMTP id ib21-20020a1709072c7500b0074158714318mr31694444ejc.532.1662491442690; Tue, 06 Sep 2022 12:10:42 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id r16-20020a50c010000000b00447bd64d4f6sm9045994edb.73.2022.09.06.12.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 12:10:42 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Subject: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table Date: Tue, 06 Sep 2022 21:10:40 +0200 Message-ID: <12048299.O9o76ZdvQC@kista> In-Reply-To: <20220906153034.153321-4-peron.clem@gmail.com> References: <20220906153034.153321-1-peron.clem@gmail.com> <20220906153034.153321-4-peron.clem@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220906_121045_395193_C3EAA545 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 06. september 2022 ob 17:30:32 CEST je Cl=E9ment P=E9ron napisal= (a): > Add an Operating Performance Points table for the GPU to > enable Dynamic Voltage & Frequency Scaling on the H6. > = > The voltage range is set with minimal voltage set to the target > and the maximal voltage set to 1.2V. This allow DVFS framework to > work properly on board with fixed regulator. > = > Signed-off-by: Cl=E9ment P=E9ron > --- > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > = > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file mode 1006= 44 > index 000000000000..b48049c4fc85 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > @@ -0,0 +1,87 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (C) 2022 Cl=E9ment P=E9ron > + > +/ { > + gpu_opp_table: opp-table-gpu { > + compatible =3D "operating-points-v2"; > + > + opp-216000000 { > + opp-hz =3D /bits/ 64 <216000000>; > + opp-microvolt =3D <810000 810000 1200000>; > + }; > + > + opp-264000000 { > + opp-hz =3D /bits/ 64 <264000000>; > + opp-microvolt =3D <810000 810000 1200000>; > + }; As mentioned in clock patch review, rates below 288 MHz are deemed unstable= on = GPU PLL by vendor GPU kernel driver. At least in the BSP version that I hav= e. = Did you test these points? If not, better to drop them. Best regards, Jernej > + > + opp-312000000 { > + opp-hz =3D /bits/ 64 <312000000>; > + opp-microvolt =3D <810000 810000 1200000>; > + }; > + > + opp-336000000 { > + opp-hz =3D /bits/ 64 <336000000>; > + opp-microvolt =3D <810000 810000 1200000>; > + }; > + > + opp-360000000 { > + opp-hz =3D /bits/ 64 <360000000>; > + opp-microvolt =3D <820000 820000 1200000>; > + }; > + > + opp-384000000 { > + opp-hz =3D /bits/ 64 <384000000>; > + opp-microvolt =3D <830000 830000 1200000>; > + }; > + > + opp-408000000 { > + opp-hz =3D /bits/ 64 <408000000>; > + opp-microvolt =3D <840000 840000 1200000>; > + }; > + > + opp-420000000 { > + opp-hz =3D /bits/ 64 <420000000>; > + opp-microvolt =3D <850000 850000 1200000>; > + }; > + > + opp-432000000 { > + opp-hz =3D /bits/ 64 <432000000>; > + opp-microvolt =3D <860000 860000 1200000>; > + }; > + > + opp-456000000 { > + opp-hz =3D /bits/ 64 <456000000>; > + opp-microvolt =3D <870000 870000 1200000>; > + }; > + > + opp-504000000 { > + opp-hz =3D /bits/ 64 <504000000>; > + opp-microvolt =3D <890000 890000 1200000>; > + }; > + > + opp-540000000 { > + opp-hz =3D /bits/ 64 <540000000>; > + opp-microvolt =3D <910000 910000 1200000>; > + }; > + > + opp-576000000 { > + opp-hz =3D /bits/ 64 <576000000>; > + opp-microvolt =3D <930000 930000 1200000>; > + }; > + > + opp-624000000 { > + opp-hz =3D /bits/ 64 <624000000>; > + opp-microvolt =3D <950000 950000 1200000>; > + }; > + > + opp-756000000 { > + opp-hz =3D /bits/ 64 <756000000>; > + opp-microvolt =3D <1040000 1040000 1200000>; > + }; > + }; > +}; > + > +&gpu { > + operating-points-v2 =3D <&gpu_opp_table>; > +}; > -- > 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel