From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: s3c24xx: get rid of custom <mach/gpio.h>
Date: Fri, 13 Dec 2013 11:30:13 +0100 [thread overview]
Message-ID: <12061693.IYmMzIp37Y@flatron> (raw)
In-Reply-To: <1386857210-4944-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
On Thursday 12 of December 2013 15:06:50 Linus Walleij wrote:
[snip]
> arch/arm/mach-s3c64xx/include/mach/gpio.h | 93 -----------------
Hmm, shouldn't this (and other s3c64xx-related changes) be in patch 2/2?
Anyway, I've applied both, but unfortunately compilation for mach-s3c64xx
(using s3c6400_defconfig) fails with following error:
CC arch/arm/plat-samsung/pm-gpio.o
In file included from arch/arm/plat-samsung/pm-gpio.c:25:0:
arch/arm/plat-samsung/include/plat/gpio-core.h:100:44: error: 'S3C_GPIO_END' undeclared here (not in a function)
extern struct samsung_gpio_chip *s3c_gpios[S3C_GPIO_END];
^
scripts/Makefile.build:308: recipe for target 'arch/arm/plat-samsung/pm-gpio.o' failed
make[1]: *** [arch/arm/plat-samsung/pm-gpio.o] Error 1
Makefile:820: recipe for target 'arch/arm/plat-samsung' failed
make: *** [arch/arm/plat-samsung] Error 2
I don't have much time right now to look at this further, but I'll try
to do it later today (if you don't fix it before that) and do further
testing.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-12-13 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 14:06 [PATCH 1/2] ARM: s3c24xx: get rid of custom <mach/gpio.h> Linus Walleij
2013-12-13 7:57 ` Heiko Stübner
2013-12-13 8:20 ` Linus Walleij
2013-12-13 8:58 ` Heiko Stübner
2013-12-13 9:18 ` kgene at kernel.org
2013-12-13 10:30 ` Tomasz Figa [this message]
2013-12-13 12:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12061693.IYmMzIp37Y@flatron \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).