From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-arm-kernel@lists.infradead.org,
Daniel Thompson <daniel.thompson@linaro.org>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 7/7] gpiolib: of: add quirk for phy reset polarity for Freescale Ethernet
Date: Wed, 12 Oct 2022 08:14:46 +0200 [thread overview]
Message-ID: <12081856.O9o76ZdvQC@steina-w> (raw)
In-Reply-To: <20221011-gpiolib-quirks-v1-7-e01d9d3e7b29@gmail.com>
Am Mittwoch, 12. Oktober 2022, 00:19:35 CEST schrieb Dmitry Torokhov:
> Bindings for Freescale Fast Ethernet Controller use a separate
> property "phy-reset-active-high" to specify polarity of its phy
> gpio line. To allow converting the driver to gpiod API we need
> to add this quirk to gpiolib.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/gpio/gpiolib-of.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 3200d705fbe3..c3d3fe4d927c 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -231,6 +231,33 @@ static void of_gpio_flags_quirks(const struct
> device_node *np, !strcmp(propname, "snps,reset-gpio") &&
> of_property_read_bool(np, "snps,reset-active-low"))
> *flags |= OF_GPIO_ACTIVE_LOW;
> +
> + /*
> + * Freescale Fast Ethernet Controller uses a separate property to
> + * describe polarity of the phy reset line.
> + */
> + if (IS_ENABLED(CONFIG_FEC)) {
> + static const char * const fec_devices[] = {
> + "fsl,imx25-fec",
> + "fsl,imx27-fec",
> + "fsl,imx28-fec",
> + "fsl,imx6q-fec",
> + "fsl,mvf600-fec",
> + "fsl,imx6sx-fec",
> + "fsl,imx6ul-fec",
> + "fsl,imx6mq-fec",
> + "fsl,imx6qm-fec",
These two should be 'fsl,imx8mq-fec' & 'fsl,imx8qm-fec' (imx8 instead of
imx6).
Best regards,
Alexander
> + "fsl,s32v234-fec",
> + NULL
> + };
> +
> + if (!strcmp(propname, "phy-reset-gpios") &&
> + of_device_compatible_match(np, fec_devices)) {
> + bool active_high = of_property_read_bool(np,
> + "phy-reset-
active-high");
> + of_gpio_quirk_polarity(np, active_high,
flags);
> + }
> + }
> }
>
> /**
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-12 6:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 22:19 [PATCH 0/7] gpiolib: more quirks to handle legacy names Dmitry Torokhov
2022-10-11 22:19 ` [PATCH 1/7] gpiolib: of: add a quirk for legacy names in Mediatek mt2701-cs42448 Dmitry Torokhov
2022-10-12 10:14 ` Daniel Thompson
2022-10-17 10:07 ` Linus Walleij
2022-10-11 22:19 ` [PATCH 2/7] gpiolib: of: consolidate simple renames into a single quirk Dmitry Torokhov
2022-10-12 10:12 ` Daniel Thompson
2022-10-12 19:20 ` Dmitry Torokhov
2022-10-13 12:59 ` Daniel Thompson
2022-10-11 22:19 ` [PATCH 3/7] gpiolib: of: add quirk for locating reset lines with legacy bindings Dmitry Torokhov
2022-10-12 10:19 ` Daniel Thompson
2022-10-11 22:19 ` [PATCH 4/7] gpiolib: of: add a quirk for reset line for Marvell NFC controller Dmitry Torokhov
2022-10-12 10:29 ` Daniel Thompson
2022-10-12 18:45 ` Dmitry Torokhov
2022-10-12 18:50 ` Daniel Thompson
2022-10-12 18:55 ` Dmitry Torokhov
2022-10-13 13:00 ` Daniel Thompson
2022-10-11 22:19 ` [PATCH 5/7] gpiolib: of: add a quirk for reset line for Cirrus CS42L56 codec Dmitry Torokhov
2022-10-12 10:30 ` Daniel Thompson
2022-10-11 22:19 ` [PATCH 6/7] gpiolib: of: factor out code overriding gpio line polarity Dmitry Torokhov
2022-10-12 11:10 ` Andy Shevchenko
2022-10-12 15:30 ` Dmitry Torokhov
2022-10-11 22:19 ` [PATCH 7/7] gpiolib: of: add quirk for phy reset polarity for Freescale Ethernet Dmitry Torokhov
2022-10-12 6:14 ` Alexander Stein [this message]
2022-10-12 15:25 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12081856.O9o76ZdvQC@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=daniel.thompson@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox