Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Steven Price <steven.price@arm.com>,
	Fuad Tabba <tabba@google.com>,
	Ackerley Tng <ackerleytng@google.com>,
	Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev,
	Catalin Marinas <catalin.marinas@arm.com>,
	Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>,
	James Morse <james.morse@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	Zenghui Yu <yuzenghui@huawei.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Joey Gouly <joey.gouly@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Christoffer Dall <christoffer.dall@arm.com>,
	linux-coco@lists.linux.dev,
	Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
	Gavin Shan <gshan@redhat.com>,
	Shanker Donthineni <sdonthineni@nvidia.com>,
	Alper Gun <alpergun@google.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
	Emi Kisanuki <fj0570is@fujitsu.com>,
	Vishal Annapurve <vannapurve@google.com>,
	WeiLin.Chang@arm.com, Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Kohei Enju <enju.kohei@fujitsu.com>
Subject: Re: [PATCH v3 01/11] KVM: arm64: guest_memfd: Check mmap support when preparing memslot
Date: Thu, 19 Nov 2026 10:10:38 +0000	[thread overview]
Message-ID: <120ad525-efa5-4129-9d97-fa6fa5db747f@arm.com> (raw)
In-Reply-To: <cc27e6a8-6bfa-4c82-92a7-33175baf6803@arm.com>

Cc: Ackerley, Sean

On 18/11/2026 15:18, Steven Price wrote:
> On 18/11/2026 12:04, Suzuki K Poulose wrote:
>> On 18/11/2026 11:14, Steven Price wrote:
>>> On 18/11/2026 10:34, Suzuki K Poulose wrote:
>>>> Hi Steven
>>>>
>>>> On 17/11/2026 14:05, Fuad Tabba wrote:
>>>>> Hi Steven,
>>>>>
>>>>> On Mon, 16 Nov 2026 16:43:47 +0000, Steven Price
>>>>> <steven.price@arm.com> wrote:
>>>>>> Check the guest_memfd backing file when deciding whether an arm64
>>>>>> memslot has mappable memory rather than checking whether the slot is
>>>>>> gmem only. A public helper function is added to be able to reuse the
>>>>>> static kvm_gmem_supports_mmap() function.
>>>>>
>>>>> nit: could the message say why this is needed? It's a no-op until
>>>>> patch 8 defines kvm_arch_has_private_mem(), which makes every
>>>>> guest_memfd slot gmem-only.
>>>>
>>>> I still don't understand why this is needed. For arm64 we have always
>>>> prevented guest_memfd without MMAP, in kvm_arch_prepare_memory_region().
>>>
>>> Fuad is correct, this isn't really needed until patch 8. Patch 8 defines
>>> kvm_arch_has_private_mem() - that means that gmem_in_place_conversion
>>> becomes true (see include/linux/kvm_host.h). That in turn means that
>>
>>> every guest_memfd slot is KVM_MEMSLOT_GMEM_ONLY including slots backed
>>> by a file without mmap support.
>>
>> But we dont support slots without MMAP anyways even without this series.
>>   So, does it really matter for arm64 ?
> 
> So ChatGPT produced the attached test. It creates a non-mappable gmem
> and tries to add it to a normal (non-realm/non-pkvm) VM. With v7.4-rc1
> it is rejected. However without this patch it succeeds.
> 
> The issue is that gmem_in_place_conversion changes the behaviour for
> normal VMs.

I see, thanks Steven. For context:

Arm64 currently (without inplace conversion support) only allows GMEM
with MMAP flags only and relies on kvm_slot_gmem_only() to detect that
the GMEM has MMAP flag. But, when we enable inplace conversion,
we can't reliably reject the slots by kvm_slot_gmem_only(), because
all GMEM slots are marked GMEM only with inplace conversion.

Also, from the API Documentation,

"When the KVM MMU performs a PFN lookup to service a guest fault, the 
fault will
always be consumed from guest_memfd, regardless of whether it is a 
shared or a
private fault (unless in-place conversion is disabled and the backing
guest_memfd does not have the GUEST_MEMFD_FLAG_MMAP flag set)."

So, in effect, with in-place conversion enabled a KVM_CREATE_GUEST_MEMFD
without GUEST_MEMFD_FLAG_MMAP is an error and thats what this patch
is trying to fix in arm64 KVM. The question is:

1) Should this be fixed ? How does TDX/SNP support older VMMs with
inplace conversion ? What was the conclusion on this breakage ?

2) If it should be, then shouldn't it be done in kvm_gmem_create() ?

Suzuki


> 
> Thanks,
> Steve
> 



  reply	other threads:[~2026-11-19 10:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 16:43 [PATCH v3 00/11] KVM: arm64: CCA: Prepare Realm memory management Steven Price
2026-11-16 16:43 ` [PATCH v3 01/11] KVM: arm64: guest_memfd: Check mmap support when preparing memslot Steven Price
2026-11-17 14:05   ` Fuad Tabba
2026-11-18 10:34     ` Suzuki K Poulose
2026-11-18 11:14       ` Steven Price
2026-11-18 12:04         ` Suzuki K Poulose
2026-11-18 15:18           ` Steven Price
2026-11-19 10:10             ` Suzuki K Poulose [this message]
2026-11-16 16:43 ` [PATCH v3 02/11] KVM: arm64: CCA: Introduce Realms Steven Price
2026-11-17 14:07   ` Fuad Tabba
2026-11-18 16:12     ` Steven Price
2026-11-16 16:43 ` [PATCH v3 03/11] KVM: arm64: Handle attributes in stage2_unmap_range Steven Price
2026-11-17 14:16   ` Fuad Tabba
2026-11-18 16:12     ` Steven Price
2026-11-16 16:43 ` [PATCH v3 04/11] KVM: arm64: CCA: Add basic infrastructure for creating a realm Steven Price
2026-11-16 16:43 ` [PATCH v3 05/11] KVM: arm64: CCA: Tear down RTTs Steven Price
2026-11-19  3:39   ` Wei-Lin Chang
2026-11-16 16:43 ` [PATCH v3 06/11] KVM: arm64: CCA: Add Realm RTT mapping and invalidation helpers Steven Price
2026-11-16 16:43 ` [PATCH v3 07/11] KVM: Allow architectures to reject memslot changes before invalidation Steven Price
2026-11-17 14:31   ` Fuad Tabba
2026-11-18 16:44     ` Steven Price
2026-11-16 16:43 ` [PATCH v3 08/11] KVM: arm64: CCA: Prevent memslot modifications after Realm creation Steven Price
2026-11-17 14:42   ` Fuad Tabba
2026-11-18 16:49     ` Steven Price
2026-11-16 16:43 ` [PATCH v3 09/11] KVM: arm64: CCA: Support runtime faulting of memory Steven Price
2026-11-19  7:48   ` Wei-Lin Chang
2026-11-16 16:43 ` [PATCH v3 10/11] KVM: arm64: Dispatch stage-2 destruction by VM flavor Steven Price
2026-11-17 15:02   ` Fuad Tabba
2026-11-18 17:04     ` Steven Price
2026-11-16 16:43 ` [PATCH v3 11/11] KVM: arm64: CCA: Add Realm stage-2 MMU operations Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=120ad525-efa5-4129-9d97-fa6fa5db747f@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=WeiLin.Chang@arm.com \
    --cc=ackerleytng@google.com \
    --cc=alexandru.elisei@arm.com \
    --cc=alpergun@google.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@arm.com \
    --cc=enju.kohei@fujitsu.com \
    --cc=fj0570is@fujitsu.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=gshan@redhat.com \
    --cc=james.morse@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=sdonthineni@nvidia.com \
    --cc=seanjc@google.com \
    --cc=steven.price@arm.com \
    --cc=tabba@google.com \
    --cc=vannapurve@google.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox