From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DE2FC27C4F for ; Thu, 13 Jun 2024 15:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N065K9zNHNGpuRaLl+nprLkgcSGQ568ihUQMVU2BLJg=; b=oQ8AFGAe0jXRdjY5St9sXCV1Qo Vw7o4L/89UtoUBcDLzuo/bDrWMNbzJem5tQigTXdeIMPvh5MXxM7R4W0KxjY8hn297353nBCh/scL 2stQzrLzufnhYL0W01j+06zclZ7taLK2wnhWc/obOCd7EmjnF1k3Dm7tizfEok9xckwjrL7GbsE4y goCHlZYUf9IUOp/bXCu3gC4zl6HYGSivcd6LsNU5ngEqb9mSPghtoZRqBA9meVieLDKGFBH/+XZxZ JvpJ43+jwfMn5soISERxnS96HO9yfDM7rcH++d1xY2Wj957DuUtjJkVUhvZzAN02BCZtEk82uFNz+ tc8sxM1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHm0t-0000000H51S-2G83; Thu, 13 Jun 2024 15:05:19 +0000 Received: from out-189.mta1.migadu.com ([95.215.58.189]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHm0q-0000000H50Y-2w8e for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 15:05:18 +0000 X-Envelope-To: christophe.jaillet@wanadoo.fr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718291114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N065K9zNHNGpuRaLl+nprLkgcSGQ568ihUQMVU2BLJg=; b=EllD0SyDBeMkOGeaIaxZmqcKY7M1zqEgbzoIkCaHrMOAvYQYbWZakznOm2clrE5nyVWOl6 eyUUR4aR/U3is3tXsblYmq7dT8Ck4YpakP8v/cayQlSkoSLy7HRNwicCpJOqO3nH50pj9K cJGZ9Kmle0+PXG9xQmxwu8+6MjnRVOI= X-Envelope-To: laurent.pinchart@ideasonboard.com X-Envelope-To: tomi.valkeinen@ideasonboard.com X-Envelope-To: maarten.lankhorst@linux.intel.com X-Envelope-To: mripard@kernel.org X-Envelope-To: tzimmermann@suse.de X-Envelope-To: airlied@gmail.com X-Envelope-To: daniel@ffwll.ch X-Envelope-To: michal.simek@amd.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kernel-janitors@vger.kernel.org X-Envelope-To: dri-devel@lists.freedesktop.org X-Envelope-To: linux-arm-kernel@lists.infradead.org Message-ID: <120ffe3c-0240-4f93-a220-e0df565bcdbf@linux.dev> Date: Thu, 13 Jun 2024 11:05:01 -0400 MIME-Version: 1.0 Subject: Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson To: Christophe JAILLET , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Michal Simek Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org References: <974d1b062d7c61ee6db00d16fa7c69aa1218ee02.1716198025.git.christophe.jaillet@wanadoo.fr> <5288867f-ee45-4930-bde0-14b24b878181@linux.dev> Content-Language: en-US In-Reply-To: <5288867f-ee45-4930-bde0-14b24b878181@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_080516_964641_F488730A X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/20/24 11:05, Sean Anderson wrote: > On 5/20/24 05:40, Christophe JAILLET wrote: >> If zynqmp_dpsub_drm_init() fails, we must undo the previous >> drm_bridge_add() call. >> >> Fixes: be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") >> Signed-off-by: Christophe JAILLET >> --- >> Compile tested only >> --- >> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c >> index face8d6b2a6f..f5781939de9c 100644 >> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c >> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c >> @@ -269,6 +269,7 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) >> return 0; >> >> err_disp: >> + drm_bridge_remove(dpsub->bridge); >> zynqmp_disp_remove(dpsub); >> err_dp: >> zynqmp_dp_remove(dpsub); > > Reviewed-by: Sean Anderson Will this be applied soon? The patch it fixes has made its way into the stable tree already. --Sean