From: nouveau@karolherbst.de (Karol Herbst)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype
Date: Fri, 15 Jan 2016 13:07:41 +0100 (CET) [thread overview]
Message-ID: <1213515825.56151.1452859661690.JavaMail.open-xchange@www.ud-mail.de> (raw)
In-Reply-To: <CACvgo50aGCMBB3Qe3o5jyV7oZ62yiDRHcLAy4xu-Nnmb5S_DaQ@mail.gmail.com>
> Emil Velikov <emil.l.velikov@gmail.com> hat am 15. Januar 2016 um 12:06
> geschrieben:
>
> On 13 January 2016 at 16:00, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday 13 January 2016 14:55:47 Karol Herbst wrote:
> >> > Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48
> >> > geschrieben:
> >> >
> >> > The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
> >> > is disabled:
> >> >
> >> > In file included from
> >> > /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
> >> > drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function
> >> > 'nouveau_debugfs_init':
> >> > drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name
> >> > omitted
> >> > nouveau_debugfs_init(struct nouveau_drm *)
> >> >
> >> > This fixes the prototypes so we can build it again.
> >> >
> >>
> >> thanks for this. I already send a patch to the nouveau ML here:
> >> http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
> >
> > Ok, thanks
> >
> Fwiw Arnd's fix feels a lot better - it lacks typos, has a fixes tag,
> comprehensive commit message etc. etc. :-)
>
> -Emil
no worries, I am still learning after all
Karol
prev parent reply other threads:[~2016-01-15 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 13:48 [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Arnd Bergmann
2016-01-13 13:55 ` Karol Herbst
2016-01-13 14:00 ` Arnd Bergmann
2016-01-15 11:06 ` Emil Velikov
2016-01-15 12:07 ` Karol Herbst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213515825.56151.1452859661690.JavaMail.open-xchange@www.ud-mail.de \
--to=nouveau@karolherbst.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).