* [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype
@ 2016-01-13 13:48 Arnd Bergmann
2016-01-13 13:55 ` Karol Herbst
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-01-13 13:48 UTC (permalink / raw)
To: linux-arm-kernel
The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
is disabled:
In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init':
drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted
nouveau_debugfs_init(struct nouveau_drm *)
This fixes the prototypes so we can build it again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b126a200e9db ("drm/nouveau/debugfs: we need a ctrl object for debugfs")
---
This broke when the nouveau patches got merged into drm-next on Monday.
Found on ARM randconfig builds.
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.h b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
index 52c7161297d7..b8c03ff5bf05 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.h
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
@@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor)
}
static inline int
-nouveau_debugfs_init(struct nouveau_drm *)
+nouveau_debugfs_init(struct nouveau_drm *drm)
{
return 0;
}
static inline void
-nouveau_debugfs_fini(struct nouveau_drm *)
+nouveau_debugfs_fini(struct nouveau_drm *drm)
{
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype
2016-01-13 13:48 [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Arnd Bergmann
@ 2016-01-13 13:55 ` Karol Herbst
2016-01-13 14:00 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Karol Herbst @ 2016-01-13 13:55 UTC (permalink / raw)
To: linux-arm-kernel
> Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48 geschrieben:
>
> The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
> is disabled:
>
> In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
> drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init':
> drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted
> nouveau_debugfs_init(struct nouveau_drm *)
>
> This fixes the prototypes so we can build it again.
>
thanks for this. I already send a patch to the nouveau ML here:
http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
but I guess I should mail to the kernel list directly next time.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b126a200e9db ("drm/nouveau/debugfs: we need a ctrl object for debugfs")
> ---
> This broke when the nouveau patches got merged into drm-next on Monday.
> Found on ARM randconfig builds.
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> index 52c7161297d7..b8c03ff5bf05 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> @@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor)
> }
>
> static inline int
> -nouveau_debugfs_init(struct nouveau_drm *)
> +nouveau_debugfs_init(struct nouveau_drm *drm)
> {
> return 0;
> }
>
> static inline void
> -nouveau_debugfs_fini(struct nouveau_drm *)
> +nouveau_debugfs_fini(struct nouveau_drm *drm)
> {
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype
2016-01-13 13:55 ` Karol Herbst
@ 2016-01-13 14:00 ` Arnd Bergmann
2016-01-15 11:06 ` Emil Velikov
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-01-13 14:00 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 13 January 2016 14:55:47 Karol Herbst wrote:
> > Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48 geschrieben:
> >
> > The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
> > is disabled:
> >
> > In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
> > drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init':
> > drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted
> > nouveau_debugfs_init(struct nouveau_drm *)
> >
> > This fixes the prototypes so we can build it again.
> >
>
> thanks for this. I already send a patch to the nouveau ML here:
> http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
Ok, thanks
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype
2016-01-13 14:00 ` Arnd Bergmann
@ 2016-01-15 11:06 ` Emil Velikov
2016-01-15 12:07 ` Karol Herbst
0 siblings, 1 reply; 5+ messages in thread
From: Emil Velikov @ 2016-01-15 11:06 UTC (permalink / raw)
To: linux-arm-kernel
On 13 January 2016 at 16:00, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 13 January 2016 14:55:47 Karol Herbst wrote:
>> > Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48 geschrieben:
>> >
>> > The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
>> > is disabled:
>> >
>> > In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
>> > drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init':
>> > drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted
>> > nouveau_debugfs_init(struct nouveau_drm *)
>> >
>> > This fixes the prototypes so we can build it again.
>> >
>>
>> thanks for this. I already send a patch to the nouveau ML here:
>> http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
>
> Ok, thanks
>
Fwiw Arnd's fix feels a lot better - it lacks typos, has a fixes tag,
comprehensive commit message etc. etc. :-)
-Emil
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype
2016-01-15 11:06 ` Emil Velikov
@ 2016-01-15 12:07 ` Karol Herbst
0 siblings, 0 replies; 5+ messages in thread
From: Karol Herbst @ 2016-01-15 12:07 UTC (permalink / raw)
To: linux-arm-kernel
> Emil Velikov <emil.l.velikov@gmail.com> hat am 15. Januar 2016 um 12:06
> geschrieben:
>
> On 13 January 2016 at 16:00, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday 13 January 2016 14:55:47 Karol Herbst wrote:
> >> > Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48
> >> > geschrieben:
> >> >
> >> > The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
> >> > is disabled:
> >> >
> >> > In file included from
> >> > /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
> >> > drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function
> >> > 'nouveau_debugfs_init':
> >> > drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name
> >> > omitted
> >> > nouveau_debugfs_init(struct nouveau_drm *)
> >> >
> >> > This fixes the prototypes so we can build it again.
> >> >
> >>
> >> thanks for this. I already send a patch to the nouveau ML here:
> >> http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
> >
> > Ok, thanks
> >
> Fwiw Arnd's fix feels a lot better - it lacks typos, has a fixes tag,
> comprehensive commit message etc. etc. :-)
>
> -Emil
no worries, I am still learning after all
Karol
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-15 12:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-13 13:48 [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Arnd Bergmann
2016-01-13 13:55 ` Karol Herbst
2016-01-13 14:00 ` Arnd Bergmann
2016-01-15 11:06 ` Emil Velikov
2016-01-15 12:07 ` Karol Herbst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).