From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CAE0C4167B for ; Mon, 4 Dec 2023 08:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=655Ei6iWBbhzZNDeq69BaUiNahVp+IJe0BmnWeYks6Y=; b=mcwkSaBfhRQGwu iF/a8aePQsi9ye8UXfmHpe3AbmhO4fSVRSmp4mz+Eqa6af8IO+mYB9e/JrsMqRkpRViHeSeoYBYhr 6OIdgCx+PbR65CpelIgCc4NQxuzdwob+H2IiSrn/pDei0mYZ99YhSf5bLaZUk9dMPiCNkVOF40jv9 gMoS+lWyJqLvAUWzbWnHMsaq272MuqEBq4MLIs7YIidj47qppV6YbfE0rM9xpWFq9+noOEIgJmvjI WpGQ6p3M72rgC0BQAs1Z1KmV7/Cj+QQMIAVlxP7x1GxjrW8YDlA65OrLKKYKLeXOFF7/EL3rSovyp ix5XXuVes8vdMRonNQvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA4Q4-003HEK-0j; Mon, 04 Dec 2023 08:35:12 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rA4Q1-003HDH-0Z for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 08:35:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1701678909; x=1733214909; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PlzrlkVoA5Lfv0X7MHh6wW4mKXUNL0QZHsEIe75p8gg=; b=GWLe5Aek/S55kJybt5D71pYdKmkyE1SiPdM0b+mXGycjz3reWaYts1a0 hPU1o0XznYnMOE+UkuYnYlCDfdquuDRfMv1axD/zdkob1kJOsP/oQs4Rg EcWag+bpjB7Kz4gDv7rIaARbr12HY40lYlB8m4p+L6JJVnC2zAlUhMeuB MzxPspBc95sRY+eAiVFMQOihbb2X6uhDsbk2ULgw9u6D9xE2hln02bskB 3SIYBcX1iYetXVeTixt0XChWP9oDNj2c8T8Ck9g8hZEiCHpyM06R6EsH7 r6A65X5s7RttI6VkzFrv1IPk/AW22rhEwaa+wfu30TIKX+K9joTPHyBXF w==; X-IronPort-AV: E=Sophos;i="6.04,249,1695679200"; d="scan'208";a="34303926" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 04 Dec 2023 09:35:01 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 966D8280075; Mon, 4 Dec 2023 09:35:01 +0100 (CET) From: Alexander Stein To: Andi Shyti Cc: Oleksij Rempel , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] i2c: imx: Make SDA actually optional for bus recovering Date: Mon, 04 Dec 2023 09:35:00 +0100 Message-ID: <12335412.O9o76ZdvQC@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231203220444.thaeuyqyv36hpv2y@zenone.zhora.eu> References: <20231130095751.65773-1-alexander.stein@ew.tq-group.com> <20231203220444.thaeuyqyv36hpv2y@zenone.zhora.eu> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_003509_616312_F18A02DA X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Sonntag, 3. Dezember 2023, 23:04:44 CET schrieb Andi Shyti: > Hi, > = > On Thu, Nov 30, 2023 at 10:57:51AM +0100, Alexander Stein wrote: > > Both i2c_generic_scl_recovery() and the debug output indicate that SDA = is > > purely optional for bus recovery. But devm_gpiod_get() never returns NU= LL > > making it mandatory. Fix this my calling devm_gpiod_get_optional instea= d. > = > ^^^^ > as Uwe pointed out, /my/by/. > = > I think Wolfram can fix this before taking it. > = > > Signed-off-by: Alexander Stein > = > otherwise: > = > Reviewed-by: Andi Shyti Thanks. Let me know if I should send a v2. Best regards, Alexander -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel