From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B2A8C32793 for ; Wed, 18 Jan 2023 12:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YZTkhBHBLhm8y3oIj8Hz/wWXUZuEPDeipYT+6sMfAyk=; b=ho0vdhaFhMJtQm vzRkyn2QzVR3UqzobL/xyu59yypyBT2OAkTXWwmAyBytw762QNm8f6RxUUK1E6i8zvjk8rchIp8lO i+cOX7JfXSXZbfROz2fa7t/mLgy8GocfPj2kuNuPBcBv+0DjP3tJJiX9u81UsoL3sLxJkf1ijlBtO x2z6Pns3yOpXiUJzwga0Ntr+9otaJHlrh1KlsX3mlhLfQqdPdphC/eBmgOsFijla9G6n/lsX4JCR1 mhh+Ep0srfGNWjz3zN3aXd8cQo5IA4MnT2apGaLcOPkL+tluYmBeP7amzYiOXNvRt1BszjbMW6O3I bHRsUzoofCjU10RF349A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI7oB-000vbu-Jm; Wed, 18 Jan 2023 12:44:52 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI7mx-000uyP-0Q for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 12:43:41 +0000 Received: by mail-wm1-x32d.google.com with SMTP id iv8-20020a05600c548800b003db04a0a46bso1350407wmb.0 for ; Wed, 18 Jan 2023 04:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6BpuBHlxhn6JmIP/U1W25BjRcHOubz4Zh2UFAiSQLEU=; b=rg+wQ13Ln8o/vCJ7FCD6BCNg51N0zz+kuwyzGaW+eB4v+6imkHl0IK7w4LKR2Uo8Z8 cREXzPewR/gI3wmeRBQ4u8h9Y5+LnHNYPAguubutmhE8JS8u6XL8sPNsk+plB25evzQ6 APUctgRkDq4sA0ba8vY+6VSdcXcyrNYO0niw91fhP947VngxcakHwRL7sTvSTSt7dlqa Fs/IVyKND7ciFfABFf4j404xOPm10MMb8JbvAGJEQhTdP1tav6nIUPDfm+tsrPFwA+En mrLBGRG7mQVfngUt/E7tjhBnKxl/gNJe/oiUoFq2jfMwQC8EPZxa/YsaxU4gZ+ZfDM5V gIBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6BpuBHlxhn6JmIP/U1W25BjRcHOubz4Zh2UFAiSQLEU=; b=7hR6cVZMMuFoQpOnCSf4pi9DXHB2XASYYiRN3Jin5//ggP3fFcFMurno56WpsgdzPn xkDkwOuvbe1MviT1LwY8E//b+qK09uUMfRjnUNlfvvynIVyKC5YLQeEFNmeaooSmxRMk lf1bZZGL9gQAQ4cFs5Pvd0DQxRkMLEWbE53s7znwNdcVn0rzSDlPKp/bQWtX703Gz3Rg tAcO1GZwyQr9U/2XE1KaJOGo2CAaLqAJAGs8ni7KnTC1vI2wHePv9tSmFJFxLyena6/H SGxIFtiY1vnXk5bfIRsojRFujERudz+P+B1U0mo9AWNae6yp0t1HKHhZs6goi2KUtywV NbaA== X-Gm-Message-State: AFqh2koJFjvo7EenOyxGdg5HrZS3aBmTDkkhIywI8Vxg4/UcwJVpFCHD GDEr6wNuCiKgTti1eHxP1vHUng== X-Google-Smtp-Source: AMrXdXv8u/F/eZG9dc2ocylK99J6Wri4Y6XHkV4l8TM6VnWGG7uhxyezbZ27wJeJ5jUWJwtppSpVDw== X-Received: by 2002:a05:600c:3b05:b0:3d6:b691:b80d with SMTP id m5-20020a05600c3b0500b003d6b691b80dmr6536563wms.21.1674045810989; Wed, 18 Jan 2023 04:43:30 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c10-20020a05600c0a4a00b003db12112fcfsm1954912wmq.4.2023.01.18.04.43.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 04:43:30 -0800 (PST) Message-ID: <12358dd7-d600-0b2c-96ab-518ee2e65404@linaro.org> Date: Wed, 18 Jan 2023 13:43:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree bindings Content-Language: en-US To: "Gupta, Nipun" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "eric.auger@redhat.com" , "alex.williamson@redhat.com" , "cohuck@redhat.com" , "song.bao.hua@hisilicon.com" , "mchehab+huawei@kernel.org" , "maz@kernel.org" , "f.fainelli@gmail.com" , "jeffrey.l.hugo@gmail.com" , "saravanak@google.com" , "Michael.Srba@seznam.cz" , "mani@kernel.org" , "yishaih@nvidia.com" , "jgg@ziepe.ca" , "jgg@nvidia.com" , "robin.murphy@arm.com" , "will@kernel.org" , "joro@8bytes.org" , "masahiroy@kernel.org" , "ndesaulniers@google.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Cc: "okaya@kernel.org" , "Anand, Harpreet" , "Agarwal, Nikhil" , "Simek, Michal" , "git (AMD-Xilinx)" References: <20230117134139.1298-1-nipun.gupta@amd.com> <20230117134139.1298-4-nipun.gupta@amd.com> <5ebee797-aa87-8db4-228c-dfe236ad32f8@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_044335_140839_A4272A87 X-CRM114-Status: UNSURE ( 8.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/01/2023 13:39, Gupta, Nipun wrote: > [AMD Official Use Only - General] Fix your email client. This is not helping us. What shall I do with it? > > > (...) >>> +properties: >>> + compatible: >>> + const: xlnx,cdxbus-controller >> >> This misses SoC specific compatible. Drop "bus" - redundant. I would >> also say - drop controller - do you see any other devices with such >> compatible naming? Use naming consistent with other devices in the >> kernel. Just open some controllers - SPI, I2C etc. and look there. > > Makes sense. Will use "xlnx,cdx" in compatible. No, this still misses device specific compatible. You did ignored half of my comment now. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel