From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69CD1C433EF for ; Thu, 3 Feb 2022 15:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VWwg0O+28W5qyM7y3mMjIqDSmU5HXnvPuKjDi4oiSWs=; b=AqNzGWV0/mkP7M LBggvQ8jcB65Dmz56X7v0d70Xk06JSf5BwF/aUbf/WtNjEfZ2puS2l6poEQqqEXhYUZBv/TrkIBBb NeC0GyWmeIoYtxS1jm799qQTNm8Id0Ela6YOvCTcoD8yml48xRB0lEszo2KG6Y9luMLZhroHKASZv 9SZIGeGNBwp5MWMYY0VJr3gF5RXKPnILfSv/AOxh0vEkxumr55CEeMY16aURFOlt3x0+JItTWXPMm FytCFhqVcH3BsCKQeXpukXE3a1Irpv0mK3/TQpyUzgRVeIhPAT00y+165imfZ1d1o2eYRcXvs2z3+ If3FQbCBgQW3qnD3DExg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFeTH-001uiE-K6; Thu, 03 Feb 2022 15:56:31 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFeTE-001uhO-3R for linux-arm-kernel@lists.infradead.org; Thu, 03 Feb 2022 15:56:29 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 213FuGqB101083; Thu, 3 Feb 2022 09:56:16 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1643903776; bh=Toar8XQdGaRCOJTQWgbWo4IklEUbtuLsEEHm1375h9s=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=uugpJAdno1/N/dQ7mLmQyX0IwyanKSZ2mHancxIP6M2awl2U4osWDxEDwBqAyjMaR daxSDEzQzNa7GLna9wL543MzxchGWud32mgXYufhHiLoP6uPqprH5hEfjPIYubCmQI mJCyQ7UjkLfxZOhAkithcK+OeMwxeH79Zi2qfR8Q= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 213FuGZS087435 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Feb 2022 09:56:16 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 3 Feb 2022 09:56:15 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 3 Feb 2022 09:56:15 -0600 Received: from [10.249.37.221] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 213FuFQO019479; Thu, 3 Feb 2022 09:56:15 -0600 Message-ID: <123d2444-9f61-7d9c-66d4-7e981dbc945f@ti.com> Date: Thu, 3 Feb 2022 09:56:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: fix regression from errata i940 fix Content-Language: en-US To: Tony Lindgren , Drew Fustini CC: Daniel Lezcano , Keerthy , , , , Tero Kristo , References: <20220202212554.1316032-1-dfustini@baylibre.com> From: Suman Anna In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220203_075628_308415_057C4D30 X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Drew, On 2/3/22 00:53, Tony Lindgren wrote: > * Drew Fustini [220202 23:26]: >> I modified the errata fix to use timer 15 and 16 instead which resolves >> the timer conflict. > > Makes sens to me, just one nit below. > >> Note: I am keeping the device tree and driver change together in one >> patch as that is how the original errata fix commit was structured. > > Yes.. The old dtb handling for the timer driver causes this dependency > unfortunately. Can you also add the cyclictest info to the commit log when you repost v2? regards Suman > >> --- a/drivers/clocksource/timer-ti-dm-systimer.c >> +++ b/drivers/clocksource/timer-ti-dm-systimer.c >> @@ -695,9 +695,9 @@ static int __init dmtimer_percpu_quirk_init(struct device_node *np, u32 pa) >> return 0; >> } >> >> - if (pa == 0x48034000) /* dra7 dmtimer3 */ >> + if (pa == 0x4882C000) /* dra7 dmtimer15 */ >> return dmtimer_percpu_timer_init(np, 0); >> - else if (pa == 0x48036000) /* dra7 dmtimer4 */ >> + else if (pa == 0x4882E000) /* dra7 dmtimer16 */ >> return dmtimer_percpu_timer_init(np, 1); >> >> return 0; > > Linux use lower case hex number typically :) > > With that, please feel free to add: > > Reviewed-by: Tony Lindgren _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel