From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69C61C4332F for ; Wed, 12 Oct 2022 13:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BxWpTdNgu7NvYGEmScKXhEp0gFLOonHuZXnMcjjuO/4=; b=tFgh7keqvl4Nw5 hCP89dNnDvYByjvvVLKoe71CX42Ph9bhyCbzKCWmY5DV8m9Hnbss7VFRoVd+zB61kh8C0IcobkN2P GCDk2YgSRumwGgjmIjozgPn+PYm19ELHgE6bdOWhDWh4hQhXDLhwkTNLLWb0ZU6wSmo75y/ZJo7jO Zw6gQnjCLOqzaFwY7+aohnlkemM7PUVKHEx3HLVYpYO9XmeCZQXb74P1N/p2GyaOXwT2oV7uq0xAW aO53aRQIn7zQZ7jdgKInebeBgC5icjp9sh7l3n4h+ug/iZ39mimRYnSwOim7TGQKpzGzK559zOnMr xu1qqfn0tlIY1xrJFzuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oibWH-0085oO-TO; Wed, 12 Oct 2022 13:11:34 +0000 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oibW2-0085jE-7H for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 13:11:26 +0000 Received: by mail-qt1-x833.google.com with SMTP id bb5so4757869qtb.11 for ; Wed, 12 Oct 2022 06:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=duZMII461PybSOKzGZSZqhJJ/qLu0MRfPY5z6dxigmI=; b=a7bw5Q23wINBvoFwz/iFZmdlemcJRCm9fhL7eS0XFlNQBZ19p4im/mcGTwHU1NAtzD jk6jZhamKzPFSoVWO4p59MOJu3n5voX+W74YhAqC7zhP2wesfnJPhWUO72deAIFWJSC7 1p84rOHvcqZr6MaJnxgvtHgl8Y7lZOjcflhrDrkG1Qpr8tBoWZAXn7m+cbyhPn418YZX PzSlw2xNcMvMAr0PyXBqclS6lkLZ6DWGl3D4omft/y9F/Aic/TZwQ8Dz3yxFtaCJM/lm JFVVbcwmfcVn4kc6k5L7cHk5gOn9ei/ckUCjW4d+no+hO8d6nJWpK6ew5z4KYzrgRvwn V2UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=duZMII461PybSOKzGZSZqhJJ/qLu0MRfPY5z6dxigmI=; b=ZvifRLC9OkCHTPYY3PGTCLq1voKM6fWtBH6AbJwR40Nzaw8zp/bIWOVXSG8PJNNdm3 RRLXPXTUphJBk8oOZUH1D0sozl0ClyNHjK68989A6/mfi0QKYl4FQt2F656G4abg/+AD pb8MyzU+F7PLppcfEFac+Z8cj34w6q0OroiBg2ZsDcd1vkALBkn82WkBnAyMh6oeAW4y TtS6MEEvsyTkz+3pCqwKOxHPfy0155q8svRLMh6vXS01a/pRjTPfv0cRy2yo/xtKGoVa KFIphBT3Bd1PRnMIOrvM4j8NK8n57WNZfKW48y3BsQPTXeqfrjUbjNsPmhC+oseSVoRP vnvg== X-Gm-Message-State: ACrzQf2rB321D1cgUXEXGO9M1M9h+2pjRo041k4BciZ8sqXMHNEkeMqn r9NU5mBVOo3219sOZzxJUET+Ew== X-Google-Smtp-Source: AMsMyM5zJrz3dx98rqmztHfBVMqSLyUW8p6tkWsBylvPbfbtBcCaSwdh6OYo7aZ0HedmoRQQhkOkng== X-Received: by 2002:ac8:7fcc:0:b0:39c:bdf4:6323 with SMTP id b12-20020ac87fcc000000b0039cbdf46323mr2836670qtk.201.1665580274377; Wed, 12 Oct 2022 06:11:14 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id he35-20020a05622a602300b0039a55f78792sm6338703qtb.89.2022.10.12.06.11.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 06:11:13 -0700 (PDT) Message-ID: <12461098-aea7-e486-f303-ef2387a6ae1f@linaro.org> Date: Wed, 12 Oct 2022 09:11:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 10/10] ARM: dts: suniv: add device tree for PopStick v1.1 Content-Language: en-US To: Icenowy Zheng , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Greg Kroah-Hartman , Andre Przywara Cc: soc@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org References: <20221012055602.1544944-1-uwu@icenowy.me> <20221012055602.1544944-11-uwu@icenowy.me> From: Krzysztof Kozlowski In-Reply-To: <20221012055602.1544944-11-uwu@icenowy.me> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_061122_299790_09CF111F X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/10/2022 01:56, Icenowy Zheng wrote: > PopStick is a minimal Allwinner F1C200s dongle, with its USB controller > wired to a USB Type-A port, a SD slot and a SPI NAND flash on board, and > an on-board CH340 USB-UART converted connected to F1C200s's UART0. (...) > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + led { > + function = LED_FUNCTION_STATUS; > + color = ; > + gpios = <&pio 4 6 GPIO_ACTIVE_HIGH>; /* PE6 */ > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + reg_vcc3v3: vcc3v3 { Generic node names, so at least generic "regulator" prefix or suffix. > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > +}; > + > +&mmc0 { > + cd-gpios = <&pio 4 3 GPIO_ACTIVE_LOW>; /* PE3 */ > + bus-width = <4>; > + disable-wp; > + status = "okay"; Keep status as last property. > + vmmc-supply = <®_vcc3v3>; > +}; > + > +&spi0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&spi0_pc_pins>; > + status = "okay"; > + > + flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "spi-nand"; > + reg = <0>; compatible and reg are by convention the first properties. > + spi-max-frequency = <40000000>; > + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel