From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79CECC4345F for ; Sat, 20 Apr 2024 23:16:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gPrqhyvpgCorbeGlOwitgCc0j1LH9hdp1LtDGDBEKKU=; b=2BXj4PV4Quwbu5 2ceEjDZi46x/ALt3ToOhXiKLnnCXU2megVo2e/W0Xg6emwnnx6xiyh/quzQnvfG8Wgs441gRxHa+g 4DBBNo06DOHjx+hVzz81ENFp7hbTQXIlbzQXq0ORR83HogTTGkUFNY8ZB6OAj3QYGcA449Zj3opht Q+AtjPKfM18G8KM2/954XDWHwsk6KBW/s1cJkN3diHW0k9C2G4rMSatHs7C+9u/4p4z+oVMsaVCYf QwkKRUoDzTuBVBVHyhCJCkjBpYHXyHbedIBtd2XHEKVLGIt0nfOMw1IzyQuMDHaTm1ZSa8Av85+5X PAhvw4vE0vejdmGHKXOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryJwC-00000009NbK-3dSO; Sat, 20 Apr 2024 23:16:04 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryJwA-00000009NZe-2ow6 for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 23:16:04 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-346b09d474dso3046464f8f.2 for ; Sat, 20 Apr 2024 16:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713654957; x=1714259757; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kQknuL+r9cbmTtmVlTx7T5fh7q9KKWBimZWASaRekHw=; b=aB/CANg57JGDN1F4xSnzpeM/xwUXJAga8bCY0CsE3mG9eomPbifUW7Wp0BylM3/E+6 soBca6mJcAXpPeWdhhwPnVUE3fb3lL42VWWEpTvmkmJh5hx5BEQ9WDfD6GogPbSHcK1E Tld3qxnA12absp8J2kaaQGWgMwiu7V2YaJ+4kUC1kRg4mqsfkjPzynxvjhPIyTcY8zE8 AButT1EnI1XrLcYxPYR82Y+xEcgI6BOgfG3o83dAZDrrWuknBPjs2koUiSKQ3YhhqzK7 IiM44Gadpz6BcNeQsEPJsNTC+fba1LGputGrwv6qketEvBQX7VK7yyEb8fvG15wq8J3B UBsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713654957; x=1714259757; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kQknuL+r9cbmTtmVlTx7T5fh7q9KKWBimZWASaRekHw=; b=RfxGxu6mfxxJv+Nnij9aA0nGLTEHgeTkbvd/NZJcKoZMusciMjjjh6pkjYV+4S0JRS LdcE+Urluqy/+zIU3EzzTi7QJJrpmWW9iCnuS4R4zgTsCf8EO6/sJi99Jb0SZBCqwOS8 Eb6xTVaxK7nj8GFSSKbKrHUoc/GsLbMRL6zEUQ0tR9R5hZwBhPhh8FSNwAspoKl4i6ve VsuYA4sTJKUIrdKeUmaCw06dpHArOGHtllOnq/n3TxLZJPmR5f0HLub6RcSYrLK//iTx NsXLtvTLVQ/RfMNT0NMPC5Euh+Vt9tWUfKr59jMdfIfq3KQJO+YIqOWF+EeroRa8zl6q odHA== X-Forwarded-Encrypted: i=1; AJvYcCXvImDQz5xfer2ZQU7yJOM3pJKWAmOV7nCY0xUvF8k04N/R3GT9lS5mV0uw+NQ3w0nouVF5FTNLS38SqluAjJkhcGgpM+sON85Zw/ubJpXUbHtq8jg= X-Gm-Message-State: AOJu0YyQXfN6gRqNDllYWKti1Xxb6skfyHJhm3T3mUyCPIc6goIRH8ts l6VdqieUQ/xgyp4XgOuhWjFZ3ptuh2mMEbabhEHESomMh+CqEk9dgQwUCOQLtfw= X-Google-Smtp-Source: AGHT+IEJ0pmo+Vbh8mjcD98mOO7pRnAuIGNTQ6Q1qc2nTTg8q3KESPbMSdkxwInYUTYo3kcHGC3OsQ== X-Received: by 2002:a05:600c:5486:b0:419:f497:632f with SMTP id iv6-20020a05600c548600b00419f497632fmr1710464wmb.29.1713654957220; Sat, 20 Apr 2024 16:15:57 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id q2-20020adfab02000000b00349d8717feasm7913040wrc.56.2024.04.20.16.15.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Apr 2024 16:15:56 -0700 (PDT) Message-ID: <124e35b3-5b0d-4bd7-848a-5c848b339157@linaro.org> Date: Sun, 21 Apr 2024 00:15:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/26] media: stm32-dcmipp: Remove redundant printk To: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> <20240419-fix-cocci-v2-6-2119e692309c@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240419-fix-cocci-v2-6-2119e692309c@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_161602_723880_6C2BEBF0 X-CRM114-Status: UNSURE ( 7.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/04/2024 10:47, Ricardo Ribalda wrote: > - if (irq <= 0) { > - return irq ? irq : -ENXIO; > - } You're dropping the original intent of the driver author there no ? when irq == 0 they want to return -ENXIO. --- bod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel