From: dwalker@fifo99.com (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] zaurus family: battery cleanups
Date: Fri, 11 Sep 2009 14:04:10 -0700 [thread overview]
Message-ID: <1252703050.28368.26.camel@desktop> (raw)
In-Reply-To: <20090911195635.GD8137@elf.ucw.cz>
On Fri, 2009-09-11 at 21:56 +0200, Pavel Machek wrote:
> On Wed 2009-09-09 07:47:11, Daniel Walker wrote:
> > On Wed, 2009-09-09 at 09:39 +0200, Pavel Machek wrote:
> > > This cleans up battery code to conform to codingstyle. The only real
> > > change is that we should now refuse to charge if we can't read battery
> > > temperature.
> >
> > This patch has a number of checkpatch errors. Mostly trailing
> > whitespace, or just spacing issues..
>
> Well, original code has problems, too, and I'm trying to slowly clean
> that up.
Ok, but your adding new problems to the code .. So eventually these new
problems would also need to get cleaned up.. If you don't add new
problems and just clean up old problems, then your moving in the right
direction (eventually no problems at all) ..
Daniel
next prev parent reply other threads:[~2009-09-11 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 7:39 [patch] zaurus family: battery cleanups Pavel Machek
2009-09-09 14:47 ` Daniel Walker
2009-09-11 19:56 ` Pavel Machek
2009-09-11 21:04 ` Daniel Walker [this message]
2009-09-15 12:45 ` [patch v2] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252703050.28368.26.camel@desktop \
--to=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).