linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: schen@mvista.com (Steve Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: remove unused code in delay.S
Date: Tue, 15 Sep 2009 11:30:10 -0500	[thread overview]
Message-ID: <1253032210.3273.128.camel@linux-1lbu> (raw)
In-Reply-To: <200909151541.08852.marek.vasut@gmail.com>

On Tue, 2009-09-15 at 15:41 +0200, Marek Vasut wrote:
> > -#if 0
> > +#if CONFIG_OLD_CPU_DELAY
> 
> ifdef please
> 
I assume this a vote in favor of considering this patch as an
alternative :)  The updated patch is below.  Since I'm only summarizing
the e-mail thread and put them into a patch (which is a less time
consuming process than continue reading and deleting e-mails on this
thread), contributors can add signed off before submitting to Russel.

Document #if 0 code block in delay.S and make it selectable for compile.

Signed-off-by: Steve Chen <schen@mvista.com>

---

 arch/arm/Kconfig     |    8 ++++++++
 arch/arm/lib/delay.S |    2 +-
 2 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index aef63c8..ca8d535 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -813,6 +813,14 @@ config ARM_ERRATA_460075
 	  ACTLR register. Note that setting specific bits in the ACTLR
register
 	  may not be available in non-secure mode.
 
+config OLD_CPU_DELAY
+	depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
+	bool "Accurate delays for older CPU"
+	def_bool n
+	help
+	  Enable if observing longer than expected delays and need more
+	  accurate delays on older CPUs.
+
 endmenu
 
 source "arch/arm/common/Kconfig"
diff --git a/arch/arm/lib/delay.S b/arch/arm/lib/delay.S
index 8d6a876..67e679b 100644
--- a/arch/arm/lib/delay.S
+++ b/arch/arm/lib/delay.S
@@ -42,7 +42,7 @@ ENTRY(__const_udelay)				@ 0 <= r0 <= 0x7fffff06
 @ Delay routine
 ENTRY(__delay)
 		subs	r0, r0, #1
-#if 0
+#ifdef CONFIG_OLD_CPU_DELAY
 		movls	pc, lr
 		subs	r0, r0, #1
 		movls	pc, lr

  reply	other threads:[~2009-09-15 16:30 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-13 21:05 [PATCH] arm: remove unused code in delay.S Felipe Contreras
2009-09-13 21:28 ` Marek Vasut
2009-09-13 23:00   ` Russell King - ARM Linux
2009-09-14  0:21     ` Jamie Lokier
2009-09-14  8:10       ` Russell King - ARM Linux
2009-09-14 12:58         ` Felipe Contreras
2009-09-14 14:00           ` Russell King - ARM Linux
2009-09-14 14:38             ` Felipe Contreras
2009-09-14 14:40               ` Russell King - ARM Linux
2009-09-14 15:14                 ` Felipe Contreras
2009-09-14 15:21                   ` Russell King - ARM Linux
2009-09-14 15:50                     ` Felipe Contreras
2009-09-14 16:25                       ` Marek Vasut
2009-09-14 16:54                         ` Felipe Contreras
2009-09-14 15:36                   ` Wolfram Sang
2009-09-14 16:06                     ` Felipe Contreras
2009-09-14 16:24                       ` Wolfram Sang
2009-09-15 10:37                   ` Pavel Machek
2009-09-15 10:47                     ` Felipe Contreras
2009-09-15 10:49                       ` Pavel Machek
2009-09-15 11:20                         ` Felipe Contreras
2009-09-15 12:29                     ` Steve Chen
2009-09-15 13:41                       ` Marek Vasut
2009-09-15 16:30                         ` Steve Chen [this message]
2009-09-15 18:58                           ` Felipe Contreras
2009-09-15 19:44                             ` Steve Chen
2009-09-15 20:39                               ` Marek Vasut
2009-09-15 21:04                               ` Krzysztof Halasa
2009-09-15 22:26                                 ` Steve Chen
2009-09-15 22:47                                   ` Krzysztof Halasa
2009-09-16  8:26                                     ` Steve Chen
2009-09-16 12:30                                       ` Krzysztof Halasa
2009-09-16 14:49                                         ` Steve Chen
2009-09-16 20:21                                           ` Sergei Shtylyov
2009-09-16 13:47                                 ` Russell King - ARM Linux
2009-09-17 19:32                                   ` Jamie Lokier
2009-09-17 19:41                                     ` Russell King - ARM Linux
2009-09-17 21:29                                       ` [PATCH v2] " Steve Chen
2009-09-17 21:37                                         ` Jamie Lokier
2009-09-17 22:25                                           ` Steve Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253032210.3273.128.camel@linux-1lbu \
    --to=schen@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).