From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Samsung SoCs: OneNAND support
Date: Thu, 17 Sep 2009 13:06:00 +0300 [thread overview]
Message-ID: <1253181960.3778.17.camel@localhost> (raw)
In-Reply-To: <9c9fda240909170302q47b306edn2d73b03243757ce1@mail.gmail.com>
On Thu, 2009-09-17 at 19:02 +0900, Kyungmin Park wrote:
> >> Very quick comment. Could you please avoid this style of putting function
> >> name to the printk? We have lots of this in onenand_base.c, and they are
> >> often wrong, because function names change.
> >>
> >> Could we please use dev_printk(), dev_dbg() and the like instead? You'll
>
> FYI: In case of MTD,
> dev_printk(), dev_dbg() not working. I used &mtd->dev,
>
> Do you know how to set the dev instead of &mtd->dev?
No, but you could investigate this.
--
Best Regards,
Artem Bityutskiy (????? ????????)
next prev parent reply other threads:[~2009-09-17 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 8:16 [PATCH] Samsung SoCs: OneNAND support Kyungmin Park
2009-09-17 8:31 ` Artem Bityutskiy
2009-09-17 9:45 ` Kyungmin Park
2009-09-17 10:02 ` Kyungmin Park
2009-09-17 10:06 ` Artem Bityutskiy [this message]
2009-09-17 20:00 ` Russell King - ARM Linux
2009-09-18 12:11 ` Makhija, Neha (IE10)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253181960.3778.17.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).