linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: schen@mvista.com (Steve Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm: remove unused code in delay.S
Date: Fri, 18 Sep 2009 16:51:49 -0500	[thread overview]
Message-ID: <1253310710.3273.294.camel@linux-1lbu> (raw)
In-Reply-To: <20090918205349.GM29905@game.jcrosoft.org>

On Fri, 2009-09-18 at 22:53 +0200, Jean-Christophe PLAGNIOL-VILLARD
wrote:
> On 15:25 Fri 18 Sep     , Steve Chen wrote:
> > On Fri, 2009-09-18 at 21:09 +0200, Uwe Kleine-K?nig wrote:
...
> > > > +	def_bool n
> > > as already noted, n is the default (that would better be expressed using
> > > "default n" btw).
> > 
> > Jean-Christope/Uwe, I'll change it to "default n".
> simply remove it will be better

Sure, I can remove it altogether.

...
> > > > +	  ARM610 and ARM710 are known to benefit from enabling this option.
> > > > +	  It should not be enabled for StrongARMs, because it is known
> > > > +	  to produce too short delays on those.
> > > > +
> > > > +	  Lastly, below are 2 lists.  The first list contains the processors
> simply remove it will be better

Remove the entire last paragraph?  I guess the header of the list does
explain everything.  I'll remove it.

...
> > > 
> > > > +	  CPUs should enable this flag
> > > > +		ARM610
> > > > +		ARM710
> > > > +
> > > > +	  CPUs should disable this flag
> > > > +		StrongARM
> > > everything armv5+ ?
> IIRC StrongARM is armv4
> ARM610 & 710 is armv3

If all armv4 are StrongARM, I can just remove it from the "depends"
list.  I'll need some help confirming.  At this point, I'm not sure what
else to change in this list.

Thanks for the inputs.

Steve

  reply	other threads:[~2009-09-18 21:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 16:46 [PATCH v3] arm: remove unused code in delay.S Steve Chen
2009-09-18 18:39 ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-18 19:09 ` Uwe Kleine-König
2009-09-18 20:25   ` Steve Chen
2009-09-18 20:53     ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-18 21:51       ` Steve Chen [this message]
2009-09-19 12:55       ` [PATCH v4] " Steve Chen
2009-09-19 13:47         ` Uwe Kleine-König
2009-09-19 14:09           ` Steve Chen
2009-09-20  0:16             ` Felipe Contreras
2009-09-20 13:18               ` Steve Chen
2009-09-19 14:04         ` [PATCH v4.1] " Steve Chen
2009-09-22 10:47           ` [PATCH v5] " Steve Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253310710.3273.294.camel@linux-1lbu \
    --to=schen@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).