linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: schen@mvista.com (Steve Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] arm: remove unused code in delay.S
Date: Sat, 19 Sep 2009 09:09:48 -0500	[thread overview]
Message-ID: <1253369389.3273.304.camel@linux-1lbu> (raw)
In-Reply-To: <20090919134731.GA11231@pengutronix.de>

On Sat, 2009-09-19 at 15:47 +0200, Uwe Kleine-K?nig wrote:
> Hello Steve,
> 
> On Sat, Sep 19, 2009 at 07:55:29AM -0500, Steve Chen wrote:
> > Document #if 0 code block in delay.S and make it selectable for compile.
> > 
> > Signed-off-by: Steve Chen <schen@mvista.com>
> > Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
> > Reviewed-by: Jamie Lokier <jamie@shareable.org>
> > Reviewed-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Reviewed-by: Krzysztof Halasa <khc@pm.waw.pl>
> > Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> > Reviewed-by: Pavel Machek <pavel@ucw.cz>
> > Reviewed-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> > Reviewed-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> I'm very surprised you added these Reviewed-by: tags.
> 
> IMO you should not add them without the explicit permission and request
> of the corresponding person.  (That means that at least mine should not
> be there.)
> 
> Moreover Reviewed-by: has a meaning (described in
> Documentation/SubmittingPatches).
> 

My only intention was to give credit to all who contributed (at least try).  I already
sent out a patch with all Reviewed-by tags removed.  I can add back in anyone who wish
to be added.

Regards,

Steve

  reply	other threads:[~2009-09-19 14:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 16:46 [PATCH v3] arm: remove unused code in delay.S Steve Chen
2009-09-18 18:39 ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-18 19:09 ` Uwe Kleine-König
2009-09-18 20:25   ` Steve Chen
2009-09-18 20:53     ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-18 21:51       ` Steve Chen
2009-09-19 12:55       ` [PATCH v4] " Steve Chen
2009-09-19 13:47         ` Uwe Kleine-König
2009-09-19 14:09           ` Steve Chen [this message]
2009-09-20  0:16             ` Felipe Contreras
2009-09-20 13:18               ` Steve Chen
2009-09-19 14:04         ` [PATCH v4.1] " Steve Chen
2009-09-22 10:47           ` [PATCH v5] " Steve Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253369389.3273.304.camel@linux-1lbu \
    --to=schen@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).