From: jaswinder@kernel.org (Jaswinder Singh Rajput)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT
Date: Sat, 26 Sep 2009 20:51:55 +0530 [thread overview]
Message-ID: <1253978515.4568.50.camel@ht.satnam> (raw)
In-Reply-To: <alpine.LFD.2.00.0909261002400.19973@localhost>
Hello Robert,
On Sat, 2009-09-26 at 10:03 -0400, Robert P. J. Day wrote:
> On Sat, 26 Sep 2009, Jaswinder Singh Rajput wrote:
>
> >
> > Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig
> >
> > Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > Cc: Byungho Min <bhmin@samsung.com>
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > Cc: Russell King <rmk+lkml@arm.linux.org.uk>
> > ---
> > arch/arm/configs/s5pc100_defconfig | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/configs/s5pc100_defconfig b/arch/arm/configs/s5pc100_defconfig
> > index b0d7d3d..94edde5 100644
> > --- a/arch/arm/configs/s5pc100_defconfig
> > +++ b/arch/arm/configs/s5pc100_defconfig
> > @@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
> > # CONFIG_DEBUG_STACK_USAGE is not set
> > CONFIG_DEBUG_LL=y
> > # CONFIG_DEBUG_ICEDCC is not set
> > -CONFIG_DEBUG_S3C_PORT=y
> > CONFIG_DEBUG_S3C_UART=0
>
> no, there is no point removing redundant entries from any of the
> defconfig files -- those files will eventually be rebuilt
> automatically at some point.
>
Who will build defconfig for old architectures like h3600_defconfig and
others.
If we are removing unused CONFIG from Kconfig then there is no point of
leaving those entries in defconfigs after all git grep keep those
entries and lead to confusions sooner or later. Yeah, for this case
where we have only entry in defconfig you sounds good but let
maintainers will decide it :-)
Thanks,
--
JSR
prev parent reply other threads:[~2009-09-26 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 14:00 [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT Jaswinder Singh Rajput
2009-09-26 14:03 ` Robert P. J. Day
2009-09-26 15:21 ` Jaswinder Singh Rajput [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253978515.4568.50.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).