public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'
Date: Thu, 14 Jul 2016 14:47:31 +0200	[thread overview]
Message-ID: <12553444.SKUaCZubIO@wuerfel> (raw)
In-Reply-To: <4080443.gtvsF1A0TV@wuerfel>

On Monday, July 11, 2016 1:40:45 PM CEST Arnd Bergmann wrote:
> On Monday, July 11, 2016 1:15:11 PM CEST Arnd Bergmann wrote:
> > On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote:
> > > On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> > > > The change to simplify of_platform_populate() had an unintended
> > > > side-effect of introducing a build warning on s3c64xx:
> > > > 
> > > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> > > > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > > > 
> > > > This adds a forward-declaration for the structure name in the
> > > > header to avoid the warning.
> > > > 
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> > > > ---
> > > > Rob, can you apply this on top of the devicetree git so we don't
> > > > have to coordinate the merges?
> > > 
> > > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > 
> > Hi Rob,
> > 
> > I still get the warning in every linux-next build, do you plan to pick
> > up the fix for the commit you merged, or should I try to work around it
> > in arm-soc and leave this as a bisection problem?
> > 
> 
> Now with Rob back on Cc.

I've applied it to arm-soc/next/cleanup now, so we can avoid the warning
in linux-next and in 4.8, though it is still present in the devicetree
git.

	Arnd

      reply	other threads:[~2016-07-14 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 11:02 [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann
2016-06-27 11:33 ` Krzysztof Kozlowski
2016-07-11 11:15   ` Arnd Bergmann
2016-07-11 11:40     ` Arnd Bergmann
2016-07-14 12:47       ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12553444.SKUaCZubIO@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox