From: shinel@foxmail.com (Shine Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:S3C2440: MINI2440 Remove some improper __initdata qualifiers
Date: Wed, 21 Oct 2009 18:13:03 +0800 [thread overview]
Message-ID: <1256119983.1940.11.camel@shinel> (raw)
In-Reply-To: <200910211129.26044.jbe@pengutronix.de>
On Wed, 2009-10-21 at 11:29 +0200, Juergen Beisert wrote:
> > -struct s3c2410fb_mach_info mini2440_fb_info __initdata = {
> > +struct s3c2410fb_mach_info mini2440_fb_info = {
> > .displays = &mini2440_lcd_cfg[0], /* not constant! see init */
> > .num_displays = 1,
> > .default_display = 0,
>
> But the other implementations in this directory are also using __initdata for
> these structures. Do they also need to remove the __initdata?
You are right. This __initdata should be kept :)
This data will be used in the function s3c24xx_fb_set_platdata which
uses memcpy to make a local copy.
> >
> > -static struct platform_device *mini2440_devices[] __initdata = {
> > +static struct platform_device *mini2440_devices[] = {
>
> You can keep this __initdata. mini2440_devices[] its used only once from a
> __init marked function.
>
This also should be maked as __initdata.
Thanks.
Best Regards,
Shine Liu
next prev parent reply other threads:[~2009-10-21 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 3:33 [PATCH] ARM:S3C2440: MINI2440 Remove some improper __initdata qualifiers Shine Liu
2009-10-21 9:29 ` Juergen Beisert
2009-10-21 10:13 ` Shine Liu [this message]
2009-10-21 14:13 ` [PATCH v2] " Shine Liu
2009-11-19 6:53 ` Shine Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256119983.1940.11.camel@shinel \
--to=shinel@foxmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).